Replace MySQL submodule by binary package

[ligurio]

• building of MySQL is time consuming operation
• checkout of submodule takes additional time (~360 sec, https://travis-ci.org/github/tarantool/libslave/jobs/734100944)

[Totktonada]

I would consider moving it back to system requirements if there are no real blockers for this way. The upstream uses such approach.

Related: tarantool/mysql-tarantool-replication#21

[ligurio]

There are several problems on a way to resolve this ticket:

1. package that brings MySQL 5.{6,7} headers to a system missed hash.h that required by one of the MySQL header
   (sql_common.h to be more precise). Bug in MySQL bug tracker - Bug #70672 | MySQL-devel package missing incluse/mysql/hash.h.

ubuntu@ubuntu-basic-1-2-10gb-sergeyb:~/libslave/build$ make
[ 14%] Building CXX object CMakeFiles/slave.dir/Slave.cpp.o
In file included from /home/ubuntu/libslave/Slave.cpp:31:
/usr/include/mysql/sql_common.h:33:10: fatal error: 'hash.h' file not found
#include <hash.h>
         ^~~~~~~~
1 error generated.

One can choose possible solution among following:

• Take hash.h in an MySQL source code repository and place it to a system directory
• Comment out string #include <hash.h> and a string with member that has a type HASH in the header sql_common.h
• Create your own fake header hash.h and include it to a sources of libslave to supress warning from compiler

2. package libmysqlclient-dev on Ubuntu 18.04, Ubuntu 19.04 and Ubuntu 20.04 provides different number of headers:

• https://packages.ubuntu.com/xenial/amd64/libmysqlclient-dev/filelist
• https://packages.ubuntu.com/bionic/amd64/libmysqlclient-dev/filelist
• https://packages.ubuntu.com/focal/amd64/libmysqlclient-dev/filelist

Missed headers contains variables and functions used in libslave source code.

Ubuntu 20.04:

[  7%] Building CXX object CMakeFiles/slave.dir/Slave.cpp.o
In file included from /home/sergeyb/sources/MRG/libslave/table.h:25,
                 from /home/sergeyb/sources/MRG/libslave/relayloginfo.h:18,
                 from /home/sergeyb/sources/MRG/libslave/slave_log_event.h:20,
                 from /home/sergeyb/sources/MRG/libslave/Slave.h:39,
                 from /home/sergeyb/sources/MRG/libslave/Slave.cpp:21:
/home/sergeyb/sources/MRG/libslave/field.h:77:26: error: ‘uint16’ was not declared in this scope; did you mean ‘uint16_t’?
   77 | template class Field_num<uint16, 1>;
      |                          ^~~~~~
      |                          uint16_t
/home/sergeyb/sources/MRG/libslave/field.h:77:35: error: template argument 1 is invalid
   77 | template class Field_num<uint16, 1>;
      |                                   ^
/home/sergeyb/sources/MRG/libslave/field.h:78:26: error: ‘uint16’ was not declared in this scope; did you mean ‘uint16_t’?
   78 | template class Field_num<uint16>;
      |                          ^~~~~~
      |                          uint16_t
/home/sergeyb/sources/MRG/libslave/field.h:78:32: error: template argument 1 is invalid
   78 | template class Field_num<uint16>;
      |                                ^
/home/sergeyb/sources/MRG/libslave/field.h:78:32: error: template argument 2 is invalid
/home/sergeyb/sources/MRG/libslave/field.h:79:26: error: ‘uint32’ was not declared in this scope; did you mean ‘rintf32’?
   79 | template class Field_num<uint32, 3>;
      |                          ^~~~~~
      |                          rintf32
/home/sergeyb/sources/MRG/libslave/field.h:79:35: error: template argument 1 is invalid
   79 | template class Field_num<uint32, 3>;
      |                                   ^
/home/sergeyb/sources/MRG/libslave/field.h:80:26: error: ‘uint32’ was not declared in this scope; did you mean ‘rintf32’?
   80 | template class Field_num<uint32>;
      |                          ^~~~~~
      |                          rintf32
/home/sergeyb/sources/MRG/libslave/field.h:80:32: error: template argument 1 is invalid
   80 | template class Field_num<uint32>;
      |                                ^
/home/sergeyb/sources/MRG/libslave/field.h:80:32: error: template argument 2 is invalid
/home/sergeyb/sources/MRG/libslave/field.h:81:26: error: ‘ulonglong’ was not declared in this scope; did you mean ‘my_ulonglong’?
   81 | template class Field_num<ulonglong>;
      |                          ^~~~~~~~~
      |                          my_ulonglong
/home/sergeyb/sources/MRG/libslave/field.h:81:35: error: template argument 1 is invalid
   81 | template class Field_num<ulonglong>;
      |                                   ^
/home/sergeyb/sources/MRG/libslave/field.h:81:35: error: template argument 2 is invalid
/home/sergeyb/sources/MRG/libslave/field.h:83:26: error: ‘int16’ was not declared in this scope; did you mean ‘int16_t’?
   83 | template class Field_num<int16, 1>;
      |                          ^~~~~
      |                          int16_t
/home/sergeyb/sources/MRG/libslave/field.h:83:34: error: template argument 1 is invalid
   83 | template class Field_num<int16, 1>;
      |                                  ^
/home/sergeyb/sources/MRG/libslave/field.h:84:26: error: ‘int16’ was not declared in this scope; did you mean ‘int16_t’?
   84 | template class Field_num<int16>;
      |                          ^~~~~
      |                          int16_t
/home/sergeyb/sources/MRG/libslave/field.h:84:31: error: template argument 1 is invalid
   84 | template class Field_num<int16>;
      |                               ^
/home/sergeyb/sources/MRG/libslave/field.h:84:31: error: template argument 2 is invalid
/home/sergeyb/sources/MRG/libslave/field.h:85:26: error: ‘int32’ was not declared in this scope; did you mean ‘rintf32’?
   85 | template class Field_num<int32, 3>;
      |                          ^~~~~
      |                          rintf32
/home/sergeyb/sources/MRG/libslave/field.h:85:34: error: template argument 1 is invalid
   85 | template class Field_num<int32, 3>;
      |                                  ^
/home/sergeyb/sources/MRG/libslave/field.h:86:26: error: ‘int32’ was not declared in this scope; did you mean ‘rintf32’?
   86 | template class Field_num<int32>;
      |                          ^~~~~
      |                          rintf32
/home/sergeyb/sources/MRG/libslave/field.h:86:31: error: template argument 1 is invalid
   86 | template class Field_num<int32>;
      |                               ^
/home/sergeyb/sources/MRG/libslave/field.h:86:31: error: template argument 2 is invalid
/home/sergeyb/sources/MRG/libslave/field.h:87:26: error: ‘longlong’ was not declared in this scope; did you mean ‘my_ulonglong’?
   87 | template class Field_num<longlong>;
      |                          ^~~~~~~~
      |                          my_ulonglong
/home/sergeyb/sources/MRG/libslave/field.h:87:34: error: template argument 1 is invalid
   87 | template class Field_num<longlong>;
      |                                  ^
/home/sergeyb/sources/MRG/libslave/field.h:87:34: error: template argument 2 is invalid
/home/sergeyb/sources/MRG/libslave/field.h: In constructor ‘slave::Field_decimal::Field_decimal(const string&, const string&, unsigned int, unsigned int, bool)’:
/home/sergeyb/sources/MRG/libslave/field.h:107:22: error: ‘::decimal_bin_size’ has not been declared
  107 |             length(::decimal_bin_size(precision, scale_))
      |                      ^~~~~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In function ‘unsigned char* {anonymous}::net_store_length_fast(unsigned char*, unsigned int)’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:55:5: error: ‘int2store’ was not declared in this scope
   55 |     int2store(packet,(unsigned int) length);
      |     ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: At global scope:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:91:1: error: ‘TYPELIB’ does not name a type
   91 | TYPELIB binlog_checksum_typelib =
      | ^~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘void slave::Slave::close_connection()’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:139:15: error: ‘::shutdown’ has not been declared
  139 |         if (::shutdown(mysql.net.fd, SHUT_RDWR) != 0)
      |               ^~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:139:38: error: ‘SHUT_RDWR’ was not declared in this scope
  139 |         if (::shutdown(mysql.net.fd, SHUT_RDWR) != 0)
      |                                      ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘void slave::Slave::createTable(slave::RelayLogInfo&, const string&, const string&, const collate_map_t&, nanomysql::Connection&) const’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:204:46: error: ‘uint16’ was not declared in this scope; did you mean ‘uint16_t’?
  204 |                     ? PtrField(new Field_num<uint16, 1>(name, type))
      |                                              ^~~~~~
      |                                              uint16_t
/home/sergeyb/sources/MRG/libslave/Slave.cpp:204:55: error: template argument 1 is invalid
  204 |                     ? PtrField(new Field_num<uint16, 1>(name, type))
      |                                                       ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:205:46: error: ‘int16’ was not declared in this scope; did you mean ‘int16_t’?
  205 |                     : PtrField(new Field_num<int16, 1>(name, type));
      |                                              ^~~~~
      |                                              int16_t
/home/sergeyb/sources/MRG/libslave/Slave.cpp:205:54: error: template argument 1 is invalid
  205 |                     : PtrField(new Field_num<int16, 1>(name, type));
      |                                                      ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:210:52: error: template argument 2 is invalid
  210 |                     ? PtrField(new Field_num<uint16>(name, type))
      |                                                    ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:211:51: error: template argument 2 is invalid
  211 |                     : PtrField(new Field_num<int16>(name, type));
      |                                                   ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:216:46: error: ‘uint32’ was not declared in this scope; did you mean ‘rintf32’?
  216 |                     ? PtrField(new Field_num<uint32, 3>(name, type))
      |                                              ^~~~~~
      |                                              rintf32
/home/sergeyb/sources/MRG/libslave/Slave.cpp:216:55: error: template argument 1 is invalid
  216 |                     ? PtrField(new Field_num<uint32, 3>(name, type))
      |                                                       ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:217:46: error: ‘int32’ was not declared in this scope; did you mean ‘rintf32’?
  217 |                     : PtrField(new Field_num<int32, 3>(name, type));
      |                                              ^~~~~
      |                                              rintf32
/home/sergeyb/sources/MRG/libslave/Slave.cpp:217:54: error: template argument 1 is invalid
  217 |                     : PtrField(new Field_num<int32, 3>(name, type));
      |                                                      ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:222:52: error: template argument 2 is invalid
  222 |                     ? PtrField(new Field_num<uint32>(name, type))
      |                                                    ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:223:51: error: template argument 2 is invalid
  223 |                     : PtrField(new Field_num<int32>(name, type));
      |                                                   ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:228:46: error: ‘ulonglong’ was not declared in this scope; did you mean ‘my_ulonglong’?
  228 |                     ? PtrField(new Field_num<ulonglong>(name, type))
      |                                              ^~~~~~~~~
      |                                              my_ulonglong
/home/sergeyb/sources/MRG/libslave/Slave.cpp:228:55: error: template argument 1 is invalid
  228 |                     ? PtrField(new Field_num<ulonglong>(name, type))
      |                                                       ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:228:55: error: template argument 2 is invalid
/home/sergeyb/sources/MRG/libslave/Slave.cpp:229:46: error: ‘longlong’ was not declared in this scope; did you mean ‘my_ulonglong’?
  229 |                     : PtrField(new Field_num<longlong>(name, type));
      |                                              ^~~~~~~~
      |                                              my_ulonglong
/home/sergeyb/sources/MRG/libslave/Slave.cpp:229:54: error: template argument 1 is invalid
  229 |                     : PtrField(new Field_num<longlong>(name, type));
      |                                                      ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:229:54: error: template argument 2 is invalid
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘void slave::Slave::register_slave_on_master(MYSQL*)’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:597:5: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  597 |     uchar buf[1024], *pos= buf;
      |     ^~~~~
      |     u_char
/home/sergeyb/sources/MRG/libslave/Slave.cpp:613:15: error: ‘pos’ was not declared in this scope; did you mean ‘pow’?
  613 |     int4store(pos, m_server_id);
      |               ^~~
      |               pow
/home/sergeyb/sources/MRG/libslave/Slave.cpp:613:5: error: ‘int4store’ was not declared in this scope
  613 |     int4store(pos, m_server_id);
      |     ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:615:37: error: expected primary-expression before ‘)’ token
  615 |     pos= net_store_data(pos, (uchar*)report_host.c_str(), report_host.size());
      |                                     ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:616:37: error: expected primary-expression before ‘)’ token
  616 |     pos= net_store_data(pos, (uchar*)report_user, report_user_len);
      |                                     ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:617:37: error: expected primary-expression before ‘)’ token
  617 |     pos= net_store_data(pos, (uchar*)report_password, report_password_len);
      |                                     ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:618:5: error: ‘int2store’ was not declared in this scope
  618 |     int2store(pos, (unsigned short) report_port);
      |     ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:627:51: error: ‘buf’ was not declared in this scope
  627 |     if (simple_command(mysql, COM_REGISTER_SLAVE, buf, (size_t) (pos-buf), 0)) {
      |                                                   ^~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:627:9: error: ‘simple_command’ was not declared in this scope
  627 |     if (simple_command(mysql, COM_REGISTER_SLAVE, buf, (size_t) (pos-buf), 0)) {
      |         ^~~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘void slave::Slave::deregister_slave_on_master(MYSQL*)’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:641:5: error: ‘simple_command’ was not declared in this scope
  641 |     simple_command(mysql, COM_QUIT, 0, 0, 1);
      |     ^~~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘void slave::Slave::do_checksum_handshake(MYSQL*)’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:744:106: error: ‘binlog_checksum_typelib’ was not declared in this scope
  744 |             m_master_info.checksum_alg = static_cast<enum_binlog_checksum_alg>(find_type(master_row[0], &binlog_checksum_typelib, 1) - 1);
      |                                                                                                          ^~~~~~~~~~~~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:744:80: error: ‘find_type’ was not declared in this scope
  744 |             m_master_info.checksum_alg = static_cast<enum_binlog_checksum_alg>(find_type(master_row[0], &binlog_checksum_typelib, 1) - 1);
      |                                                                                ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘int slave::Slave::process_event(const slave::Basic_event_info&, slave::RelayLogInfo&)’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:860:88: error: ‘uint2korr’ was not declared in this scope
  860 |                         static_cast<Field_string*>(table->fields[i].get())->set_length(uint2korr(metadata));
      |                                                                                        ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘void slave::Slave::request_dump_wo_gtid(const string&, long unsigned int, MYSQL*)’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:948:5: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  948 |     uchar buf[128];
      |     ^~~~~
      |     u_char
/home/sergeyb/sources/MRG/libslave/Slave.cpp:959:15: error: ‘buf’ was not declared in this scope
  959 |     int4store(buf, (uint32)start_position);
      |               ^~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:959:21: error: ‘uint32’ was not declared in this scope; did you mean ‘rintf32’?
  959 |     int4store(buf, (uint32)start_position);
      |                     ^~~~~~
      |                     rintf32
/home/sergeyb/sources/MRG/libslave/Slave.cpp:959:5: error: ‘int4store’ was not declared in this scope
  959 |     int4store(buf, (uint32)start_position);
      |     ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:960:5: error: ‘int2store’ was not declared in this scope
  960 |     int2store(buf + BIN_LOG_HEADER_SIZE, binlog_flags);
      |     ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:967:9: error: ‘simple_command’ was not declared in this scope
  967 |     if (simple_command(mysql, COM_BINLOG_DUMP, buf, logname_len + 10, 1)) {
      |         ^~~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘void slave::Slave::request_dump(const slave::Position&, MYSQL*)’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:984:9: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  984 |         uchar* buf = (uchar*)malloc(encoded_size + 22);
      |         ^~~~~
      |         u_char
/home/sergeyb/sources/MRG/libslave/Slave.cpp:984:16: error: ‘buf’ was not declared in this scope
  984 |         uchar* buf = (uchar*)malloc(encoded_size + 22);
      |                ^~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:984:29: error: expected primary-expression before ‘)’ token
  984 |         uchar* buf = (uchar*)malloc(encoded_size + 22);
      |                             ^
/home/sergeyb/sources/MRG/libslave/Slave.cpp:986:9: error: ‘int2store’ was not declared in this scope
  986 |         int2store(buf, 4);
      |         ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:987:9: error: ‘int4store’ was not declared in this scope
  987 |         int4store(buf + 2, m_server_id);
      |         ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:989:9: error: ‘int8store’ was not declared in this scope
  989 |         int8store(buf + 10, 4LL);
      |         ^~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:994:13: error: ‘simple_command’ was not declared in this scope
  994 |         if (simple_command(mysql, COM_BINLOG_DUMP_GTID, buf, encoded_size + 22, 1))
      |             ^~~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: In member function ‘ulong slave::Slave::read_event(MYSQL*)’:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:1017:11: error: ‘cli_safe_read’ was not declared in this scope
 1017 |     len = cli_safe_read(mysql, nullptr);
      |           ^~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp: At global scope:
/home/sergeyb/sources/MRG/libslave/Slave.cpp:84:14: warning: ‘{anonymous}::binlog_checksum_type_length’ defined but not used [-Wunused-variable]
   84 | unsigned int binlog_checksum_type_length[] =
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:77:13: warning: ‘{anonymous}::binlog_checksum_type_names’ defined but not used [-Wunused-variable]
   77 | const char* binlog_checksum_type_names[] =
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sergeyb/sources/MRG/libslave/Slave.cpp:59:16: warning: ‘unsigned char* {anonymous}::net_store_data(unsigned char*, const unsigned char*, unsigned int)’ defined but not used [-Wunused-function]
   59 | unsigned char *net_store_data(unsigned char *to, const unsigned char *from, unsigned int length)
      |                ^~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/slave.dir/build.make:63: CMakeFiles/slave.dir/Slave.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:98: CMakeFiles/slave.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Ubuntu 19.04

[ 14%] Building CXX object CMakeFiles/slave.dir/field.cpp.o
/home/ubuntu/libslave/field.cpp:156:20: error: no member named 'my_timestamp_binary_length' in the global namespace
        length = ::my_timestamp_binary_length(precision);
                 ~~^
/home/ubuntu/libslave/field.cpp:168:11: error: no member named 'my_timestamp_from_binary' in the global namespace
        ::my_timestamp_from_binary(&tv, (const uchar*)from, precision);
        ~~^
/home/ubuntu/libslave/field.cpp:189:18: error: use of undeclared identifier 'MAX_DATE_STRING_REP_LENGTH'
    char buffer[ MAX_DATE_STRING_REP_LENGTH ];
                 ^
/home/ubuntu/libslave/field.cpp:190:32: error: no member named 'my_TIME_to_str' in the global namespace
    const int value_length = ::my_TIME_to_str(my_time, (char*)&buffer, precision);
                             ~~^
/home/ubuntu/libslave/field.cpp:209:20: error: no member named 'my_time_binary_length' in the global namespace
        length = ::my_time_binary_length(precision);
                 ~~^
/home/ubuntu/libslave/field.cpp:219:15: error: no member named 'number_to_time' in the global namespace
        if (::number_to_time(nr, &my_time, &warnings) || warnings) {
            ~~^
/home/ubuntu/libslave/field.cpp:223:25: error: no member named 'my_time_packed_from_binary' in the global namespace
        longlong nr = ::my_time_packed_from_binary((const uchar*)from, precision);
                      ~~^
/home/ubuntu/libslave/field.cpp:224:11: error: no member named 'TIME_from_longlong_time_packed' in the global namespace
        ::TIME_from_longlong_time_packed(&my_time, nr);
        ~~^
/home/ubuntu/libslave/field.cpp:227:18: error: use of undeclared identifier 'MAX_DATE_STRING_REP_LENGTH'
    char buffer[ MAX_DATE_STRING_REP_LENGTH ];
                 ^
/home/ubuntu/libslave/field.cpp:228:32: error: no member named 'my_TIME_to_str' in the global namespace
    const int value_length = ::my_TIME_to_str(my_time, (char*)&buffer, precision);
                             ~~^
/home/ubuntu/libslave/field.cpp:247:20: error: no member named 'my_datetime_binary_length' in the global namespace
        length = ::my_datetime_binary_length(precision);
                 ~~^
/home/ubuntu/libslave/field.cpp:257:15: error: no member named 'number_to_datetime' in the global namespace
        if (::number_to_datetime(nr, &my_time, TIME_FUZZY_DATE, &warnings) == -1 || warnings) {

            ~~^
/home/ubuntu/libslave/field.cpp:257:48: error: use of undeclared identifier 'TIME_FUZZY_DATE'
        if (::number_to_datetime(nr, &my_time, TIME_FUZZY_DATE, &warnings) == -1 || warnings) {
                                               ^
/home/ubuntu/libslave/field.cpp:261:25: error: no member named 'my_datetime_packed_from_binary' in the global namespace
        longlong nr = ::my_datetime_packed_from_binary((const uchar*)from, precision);
                      ~~^
/home/ubuntu/libslave/field.cpp:262:11: error: no member named 'TIME_from_longlong_datetime_packed' in the global namespace
        ::TIME_from_longlong_datetime_packed(&my_time, nr);
        ~~^
/home/ubuntu/libslave/field.cpp:265:18: error: use of undeclared identifier 'MAX_DATE_STRING_REP_LENGTH'
    char buffer[ MAX_DATE_STRING_REP_LENGTH ];
                 ^
/home/ubuntu/libslave/field.cpp:266:32: error: no member named 'my_TIME_to_str' in the global namespace
    const int value_length = ::my_TIME_to_str(my_time, (char*)&buffer, precision);
                             ~~^
/home/ubuntu/libslave/field.cpp:288:18: error: use of undeclared identifier 'MAX_DATE_STRING_REP_LENGTH'
    char buffer[ MAX_DATE_STRING_REP_LENGTH ];
                 ^
/home/ubuntu/libslave/field.cpp:289:32: error: no member named 'my_TIME_to_str' in the global namespace
    const int value_length = ::my_TIME_to_str(my_time, (char*)&buffer, 0);
                             ~~^
19 errors generated.
CMakeFiles/slave.dir/build.make:158: recipe for target 'CMakeFiles/slave.dir/field.cpp.o' failed
make[2]: *** [CMakeFiles/slave.dir/field.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/slave.dir/all' failed
make[1]: *** [CMakeFiles/slave.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

[Totktonada]

Am I understood it right: we should stop depending on mysql internals and use only those types and functions that are provided by the public libmysqclient headers and the library symbols?