Small fixes (#65)

* Add conditional test when to add wp3.8 style fix

No need to include it for later wordpress versions so
it won't break anything for future versions by mistake.

Signed-off-by: Roi Dayan <[email protected]>

* Invoke change event on wpsa-url input

External js might listen to change event of the input field.

Signed-off-by: Roi Dayan <[email protected]>

* Allow optional label field

It's not needed for example for the html field.

Signed-off-by: Roi Dayan <[email protected]>

* Small refactor to adding settings fields

To be more readable.

Signed-off-by: Roi Dayan <[email protected]>

Author: roidayan

src/class.settings-api.php

@@ -119,13 +119,16 @@ function admin_init() {
         foreach ( $this->settings_fields as $section => $field ) {
             foreach ( $field as $option ) {
 
+                $name = $option['name'];
                 $type = isset( $option['type'] ) ? $option['type'] : 'text';
+                $label = isset( $option['label'] ) ? $option['label'] : '';
+                $callback = isset( $option['callback'] ) ? $option['callback'] : array( $this, 'callback_' . $type );
 
                 $args = array(
-                    'id'                => $option['name'],
-                    'label_for'         => $args['label_for'] = "{$section}[{$option['name']}]",
+                    'id'                => $name,
+                    'label_for'         => $args['label_for'] = "{$section}[{$name}]",
                     'desc'              => isset( $option['desc'] ) ? $option['desc'] : '',
-                    'name'              => $option['label'],
+                    'name'              => $label,
                     'section'           => $section,
                     'size'              => isset( $option['size'] ) ? $option['size'] : null,
                     'options'           => isset( $option['options'] ) ? $option['options'] : '',
@@ -138,7 +141,7 @@ function admin_init() {
                     'step'              => isset( $option['step'] ) ? $option['step'] : '',
                 );
 
-                add_settings_field( $section . '[' . $option['name'] . ']', $option['label'], (isset($option['callback']) ? $option['callback'] : array($this, 'callback_' . $type )), $section, $section, $args );
+                add_settings_field( "{$section}[{$name}]", $label, $callback, $section, $section, $args );
             }
         }
 
@@ -594,22 +597,30 @@ function(){
 
                     file_frame.on('select', function () {
                         attachment = file_frame.state().get('selection').first().toJSON();
-
-                        self.prev('.wpsa-url').val(attachment.url);
+                        self.prev('.wpsa-url').val(attachment.url).change();
                     });
 
                     // Finally, open the modal
                     file_frame.open();
                 });
         });
         </script>
+        <?php
+        $this->_style_fix();
+    }
 
+    function _style_fix() {
+        global $wp_version;
+
+        if (version_compare($wp_version, '3.8', '<=')):
+        ?>
         <style type="text/css">
             /** WordPress 3.8 Fix **/
             .form-table th { padding: 20px 10px; }
             #wpbody-content .metabox-holder { padding-top: 5px; }
         </style>
         <?php
+        endif;
     }
 
 }