Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image field #43

Open
tareq1988 opened this issue May 19, 2015 · 8 comments
Open

Image field #43

tareq1988 opened this issue May 19, 2015 · 8 comments

Comments

@tareq1988
Copy link
Owner

Now we have a file upload field and it contains a input field with the URL of the selected file. It would be better to have a image field with a image thumbnail preview.

@roidayan
Copy link
Contributor

I already have this by adding description to add the preview and small js.
I'm not sure it's good to force this in the class it self. maybe with an option.
Maybe first we should split types file and media? or at least rename this to media type?

@roidayan
Copy link
Contributor

maybe to rename this callback type to image ? it isn't really for files but for images..

@roidayan
Copy link
Contributor

see my suggestion here #45

@tareq1988
Copy link
Owner Author

I think you misunderstood me. The file type will be there as it is. But I am talking about creating an image only type. So we will have both file and image type fields. Sorry if I was not clear enough.

@roidayan
Copy link
Contributor

so the image type will be the same as file but with preview?

I thought the file will be input type="file"

@tareq1988
Copy link
Owner Author

Yeah, the image type will be the same is file. Except the input box with URL and will show the image preview.

@roidayan
Copy link
Contributor

related pr #47

@nk-o
Copy link

nk-o commented Sep 9, 2017

Hey, @tareq1988. Any chance to add this field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants