From 8aeba4dcd62ea018d0dba22193cd8777d9a4534f Mon Sep 17 00:00:00 2001 From: boghy933 Date: Thu, 21 Sep 2017 10:50:59 +0200 Subject: [PATCH 1/4] check if settings_sections and settings_fields are array before foreach --- src/class.settings-api.php | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/class.settings-api.php b/src/class.settings-api.php index e73d470..030e9a0 100755 --- a/src/class.settings-api.php +++ b/src/class.settings-api.php @@ -97,6 +97,8 @@ function add_field( $section, $field ) { * registers them to WordPress and ready for use. */ function admin_init() { + if( ! is_array( $this->settings_sections ) ) + return ; //register settings sections foreach ( $this->settings_sections as $section ) { if ( false == get_option( $section['id'] ) ) { @@ -115,6 +117,8 @@ function admin_init() { add_settings_section( $section['id'], $section['title'], $callback, $section['id'] ); } + if( ! is_array($this->settings_fields) ) + return ; //register settings fields foreach ( $this->settings_fields as $section => $field ) { foreach ( $field as $option ) { @@ -502,6 +506,9 @@ function get_option( $option, $section, $default = '' ) { function show_navigation() { $html = '

'; + if( ! is_array( $this->settings_sections ) ) + return ; + $count = count( $this->settings_sections ); // don't show the navigation if only one section exists @@ -524,6 +531,8 @@ function show_navigation() { * This function displays every sections in a different form */ function show_forms() { + if( ! is_array( $this->settings_sections ) ) + return ; ?>
settings_sections as $form ) { ?> @@ -566,15 +575,15 @@ function script() { if (typeof(localStorage) != 'undefined' ) { activetab = localStorage.getItem("activetab"); } - + //if url has section id as hash then set it as active or override the current local storage value if(window.location.hash){ activetab = window.location.hash; if (typeof(localStorage) != 'undefined' ) { localStorage.setItem("activetab", activetab); - } - } - + } + } + if (activetab != '' && $(activetab).length ) { $(activetab).fadeIn(); } else { From 7254c51a6d945a507b7f5b3c69723af509b58259 Mon Sep 17 00:00:00 2001 From: boghy933 Date: Mon, 2 Oct 2017 14:59:56 +0200 Subject: [PATCH 2/4] added post_type on pages dropdown --- src/class.settings-api.php | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/class.settings-api.php b/src/class.settings-api.php index 030e9a0..2744e2a 100755 --- a/src/class.settings-api.php +++ b/src/class.settings-api.php @@ -144,6 +144,7 @@ function admin_init() { 'min' => isset( $option['min'] ) ? $option['min'] : '', 'max' => isset( $option['max'] ) ? $option['max'] : '', 'step' => isset( $option['step'] ) ? $option['step'] : '', + 'post_type' => isset( $option['post_type'] ) ? $option['post_type'] : 'page', ); add_settings_field( "{$section}[{$name}]", $label, $callback, $section, $section, $args ); @@ -419,11 +420,16 @@ function callback_color( $args ) { function callback_pages( $args ) { $dropdown_args = array( - 'selected' => esc_attr($this->get_option($args['id'], $args['section'], $args['std'] ) ), - 'name' => $args['section'] . '[' . $args['id'] . ']', - 'id' => $args['section'] . '[' . $args['id'] . ']', - 'echo' => 0 + 'selected' => esc_attr($this->get_option($args['id'], $args['section'], $args['std'] ) ), + 'name' => $args['section'] . '[' . $args['id'] . ']', + 'id' => $args['section'] . '[' . $args['id'] . ']', + 'echo' => 0, + 'post_type' => $args['post_type'], + 'hierarchical' => true, ); + + // var_dump($dropdown_args); + $html = wp_dropdown_pages( $dropdown_args ); echo $html; } From 547f576474b0572ead417b815439a2f2827478c0 Mon Sep 17 00:00:00 2001 From: boghy933 Date: Mon, 2 Oct 2017 15:13:03 +0200 Subject: [PATCH 3/4] added show_option_none for dropdown pages --- src/class.settings-api.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/class.settings-api.php b/src/class.settings-api.php index 2744e2a..ba796e7 100755 --- a/src/class.settings-api.php +++ b/src/class.settings-api.php @@ -426,6 +426,7 @@ function callback_pages( $args ) { 'echo' => 0, 'post_type' => $args['post_type'], 'hierarchical' => true, + 'show_option_none' => '— Select —', ); // var_dump($dropdown_args); From 0104032292f7b7c86c922203cabb0dfde6c49ee5 Mon Sep 17 00:00:00 2001 From: boghy933 Date: Wed, 18 Oct 2017 12:09:27 +0200 Subject: [PATCH 4/4] added description to the select_page --- src/class.settings-api.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/class.settings-api.php b/src/class.settings-api.php index ba796e7..c789e8c 100755 --- a/src/class.settings-api.php +++ b/src/class.settings-api.php @@ -428,10 +428,8 @@ function callback_pages( $args ) { 'hierarchical' => true, 'show_option_none' => '— Select —', ); - - // var_dump($dropdown_args); - $html = wp_dropdown_pages( $dropdown_args ); + $html .= $this->get_field_description( $args ); echo $html; }