'dune subst' has been disabled in this project

[talex5]

dune-release fails with:

$ dune-release
[-] Building source archive
File "dune-project", line 4, characters 7-15:
4 | (subst disabled)
           ^^^^^^^^
Error: 'dune subst' has been disabled in this project. Any use of it is
forbidden.
Hint: If you wish to re-enable it, change to (subst enabled) in the
dune-project file.
dune-release: [ERROR] run ['dune' 'subst']: exited with 1

If subst is disabled, then it's not needed and dune-release should skip this, I think. Removing this line fixed it for me:

dune-release/lib/pkg.ml

Line 446 in 80ce7b5

Sos.run ~dry_run Cmd.(v "dune" % "subst") >>= fun () ->

I also tried with dune-release --dry-run and that got further, but then crashed with:

-: exec: git --git-dir .git checkout --orphan gh-pages
dune-release: internal error, uncaught exception:
              File "lib/sos.ml", line 35, characters 28-34: Assertion failed

[Leonidas-from-XIV]

In a way I am not even sure that the dune behavior is even correct here; maybe it should just silently do nothing (or print a warning and succeed) since the point of subst disabled is to disable substitution; it doesn't need to break shell commands.

Otherwise we'd need to parse dune-project and see if it is enabled or not; that's kind of annoying as I am not aware of a good way to query dune itself for the information. Or call dune subst and if it fails ignore the failure.

[psafont]

I'm able to get around the issue and produce the tarball with dune-release --dry-run. It's unfortunate because I had to disable subst because of a dune bug in a past version.