Skip to content

Support for AsgiFastStream with AppWrapper ? #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yann-combarnous opened this issue Mar 20, 2025 · 5 comments
Closed

Support for AsgiFastStream with AppWrapper ? #77

yann-combarnous opened this issue Mar 20, 2025 · 5 comments

Comments

@yann-combarnous
Copy link
Contributor

Currently, the following errors out, saying that AsgiFastStream is not supported by AppWrapper.

It would be nice to be able to monitor the broker is alive like regular FastSteam broker, for instance with:

app = FastStream(broker, logger=logger).as_asgi(
    asgi_routes=[
        ("/liveness", liveness_ping),
    ],
)
taskiq_broker = AppWrapper(app)

Or maybe by applying asgi to taskiq_broker

@Lancetnik
Copy link
Collaborator

@yann-combarnous seems like it works correctly, just a type hints problem

@yann-combarnous
Copy link
Contributor Author

yann-combarnous commented May 4, 2025

@yann-combarnous seems like it works correctly, just a type hints problem

That’s correct. On a side note, I also noticed async generator functions also had a type hint issue.

@Lancetnik
Copy link
Collaborator

@yann-combarnous seems like it works correctly, just a type hints problem

That’s correct. On a side note, I also noticed async generator functions also had a type hint issue.

Can you create a PR to fix it? Or give me more information about the problem, please (link to the code line or smth)

@yann-combarnous
Copy link
Contributor Author

@yann-combarnous seems like it works correctly, just a type hints problem

That’s correct. On a side note, I also noticed async generator functions also had a type hint issue.

Can you create a PR to fix it? Or give me more information about the problem, please (link to the code line or smth)

Will check out latest version tomorrow, and create PR if needed.

@yann-combarnous
Copy link
Contributor Author

@yann-combarnous seems like it works correctly, just a type hints problem

That’s correct. On a side note, I also noticed async generator functions also had a type hint issue.

Can you create a PR to fix it? Or give me more information about the problem, please (link to the code line or smth)

Will check out latest version tomorrow, and create PR if needed.

@Lancetnik , PR added here: #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants