Allow empty strings in url and base_url. Resolves #51.

Author: tcdent

README.markdown

@@ -245,7 +245,7 @@ The test package includes a simple server script which returns debug information
 
 ``` sh
 $ php -S localhost:8888 RestClientTest.php
-$ phpunit RestClientTest
+$ phpunit RestClientTest.php
 ```
 
 * Requires PHP > 5.5.7 in order for `getallheaders` data to populate.

RestClientTest.php

@@ -211,6 +211,39 @@ public function test_build_non_indexed_queries() : void {
         $this->assertEquals("foo=+bar&baz=1&bat%5B%5D=foo&bat%5B%5D=bar&bat%5B%5D=baz%5B12%5D", 
             $response_json->SERVER->QUERY_STRING);
     }
+
+    public function test_empty_base_url() : void {
+        global $TEST_SERVER_URL;
+
+        $api = new RestClient(
+            ['base_url' => null]
+        );
+        $result = $api->get($TEST_SERVER_URL);
+        $this->assertEquals(200, $result->info->http_code);
+    }
+
+    public function test_empty_url() : void {
+        global $TEST_SERVER_URL;
+
+        $api = new RestClient(
+            ['base_url' => $TEST_SERVER_URL]
+        );
+        $result = $api->get('');
+        $this->assertEquals(200, $result->info->http_code);
+    }
+
+    public function test_null_url() : void {
+        global $TEST_SERVER_URL;
+
+        $api = new RestClient(
+            ['base_url' => $TEST_SERVER_URL]
+        );
+        try {
+            $result = $api->get(null);
+        } catch (TypeError $e) {
+            $this->assertEquals(TypeError::class, get_class($e));
+        }
+    }
 }
 
 

restclient.php

@@ -188,9 +188,9 @@ public function execute(string $url, string $method='GET', $parameters=[], array
         }
 
         if($client->options['base_url']){
-            if($client->url[0] !== '/' && substr($client->options['base_url'], -1) !== '/')
-                $client->url = '/' . $client->url;
-            $client->url = $client->options['base_url'] . $client->url;
+            $client->url = sprintf("%s/%s",
+                rtrim((string) $client->options['base_url'], '/'), 
+                ltrim((string) $client->url, '/'));
         }
         $curlopt[CURLOPT_URL] = $client->url;