CI: Remove shebang from non-executable scripts

tcharding · tcharding · commit 60ab3d26e5d5 · 2024-05-31T10:10:00.000+10:00
Some of our CI shell scripts are meant only to be sourced and not run directly however they include an initial shebang line, implying that they should be run. Remove the shebang line from `crates.sh` and the various `test_vars.sh` scripts. Add a `shellcheck` directive to inhibit the no-shebang warning. Fix: rust-bitcoin#2764
diff --git a/base58/contrib/test_vars.sh b/base58/contrib/test_vars.sh
@@ -1,4 +1,6 @@
-#!/usr/bin/env bash
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
 # disable verify unused vars, despite the fact that they are used when sourced
 # shellcheck disable=SC2034
 
diff --git a/bitcoin/contrib/test_vars.sh b/bitcoin/contrib/test_vars.sh
@@ -1,4 +1,6 @@
-#!/usr/bin/env bash
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
 # disable verify unused vars, despite the fact that they are used when sourced
 # shellcheck disable=SC2034
 
diff --git a/contrib/crates.sh b/contrib/crates.sh
@@ -1,4 +1,6 @@
-#!/usr/bin/env bash
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
 # disable verify unused vars, despite the fact that they are used when sourced
 # shellcheck disable=SC2034
 
diff --git a/contrib/test_vars.sh b/contrib/test_vars.sh
@@ -1,4 +1,6 @@
-#!/usr/bin/env bash
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
 #
 # Used by labeler.yaml
 #
diff --git a/hashes/contrib/test_vars.sh b/hashes/contrib/test_vars.sh
@@ -1,4 +1,6 @@
-#!/usr/bin/env bash
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
 # disable verify unused vars, despite the fact that they are used when sourced
 # shellcheck disable=SC2034
 
diff --git a/internals/contrib/test_vars.sh b/internals/contrib/test_vars.sh
@@ -1,4 +1,6 @@
-#!/usr/bin/env bash
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
 # disable verify unused vars, despite the fact that they are used when sourced
 # shellcheck disable=SC2034
 
diff --git a/io/contrib/test_vars.sh b/io/contrib/test_vars.sh
@@ -1,4 +1,6 @@
-#!/usr/bin/env bash
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
 # disable verify unused vars, despite the fact that they are used when sourced
 # shellcheck disable=SC2034
 
diff --git a/units/contrib/test_vars.sh b/units/contrib/test_vars.sh
@@ -1,4 +1,6 @@
-#!/usr/bin/env bash
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
 # disable verify unused vars, despite the fact that they are used when sourced
 # shellcheck disable=SC2034
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,6 @@`
`1`		`-#!/usr/bin/env bash`
	`1`	`+# No shebang, this file should not be executed.`
	`2`	`+# shellcheck disable=SC2148`
	`3`	`+#`
`2`	`4`	`#`
`3`	`5`	`# Used by labeler.yaml`
`4`	`6`	`#`