Skip to content

Pipeline: Support set pod template for tasks #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wuhuizuo opened this issue Apr 24, 2023 · 17 comments · May be fixed by #8599
Open

Pipeline: Support set pod template for tasks #6742

wuhuizuo opened this issue Apr 24, 2023 · 17 comments · May be fixed by #8599
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@wuhuizuo
Copy link

Feature request

Support set pod template for tasks in Pipeline resource.

Use case

I want a pipeline with two parallel tasks, one task run on AMD64 arch node and another run on ARM64 node.
Currently only PipelineRun support pod template to do it, but it's complex for my case, it should decide internal by params.

@wuhuizuo wuhuizuo added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 24, 2023
@dibyom dibyom transferred this issue from tektoncd/community May 30, 2023
@lbernick
Copy link
Member

@wuhuizuo would matrix work for your use case?

@vdemeester
Copy link
Member

@wuhuizuo would matrix work for your use case?

It doesn't as it doesn't "apply" to PipelineRun and in that particular case, taskRunTemplate/taskRunspecs (because this is where we can set topology constraint, …).

@wuhuizuo
Copy link
Author

wuhuizuo commented Jul 21, 2023

@wuhuizuo would matrix work for your use case?

No, it can not. That's I want: set arch in params or matrix to make parallel tasks on different arch nodes.

@vdemeester
Copy link
Member

@lbernick @jerop this is a "shortcoming" of the matrix work that is making it a bit less useful than I thought it would to be honest 🙃

@jerop
Copy link
Member

jerop commented Jul 24, 2023

@vdemeester would matrix at the pipeline level be more useful?

@vdemeester
Copy link
Member

@jerop I don't think it would solve too much (or even what it would look like — except if it's a typo and you meant pipelinerun 😛). The main trick is, when you want to use matrix for some runtime information. The basic example that comes to mind is for multi-arch build on nodes with different architecture (on a heterogenous cluster). Today, we cannot do this with matrix, because those are runtime information, that cannot benefit from the matrix feature I believe.

@jerop
Copy link
Member

jerop commented Jul 26, 2023

yes, I meant pipelinerun 🙃

pipeline declares string params, and pipelinerun provides array params to fan out to multiple child pipelineruns

seems to me that will help with the multi-arch use case, right?

@vdemeester
Copy link
Member

seems to me that will help with the multi-arch use case, right?

It helps if we use cross-compilation to do multi-arch build, but it doesn't if we need the "host" to be a certain architecture (as of today I mean).

@wuhuizuo
Copy link
Author

seems to me that will help with the multi-arch use case, right?

It helps if we use cross-compilation to do multi-arch build, but it doesn't if we need the "host" to be a certain architecture (as of today I mean).

@vdemeester
Sorry for late reply, not just for building, may be some tests(unit tests or integration tests ...) need run on different-arch nodes.

@wuhuizuo
Copy link
Author

I would like to implement it. ❤️

@wuhuizuo
Copy link
Author

/cc wuhuizuo

@wuhuizuo
Copy link
Author

/assign wuhuizuo

@raballew
Copy link
Contributor

@wuhuizuo Any update on your efforts to implement this feature?

@jwx0925
Copy link

jwx0925 commented May 13, 2024

Any update ?
In our case, we have changed the parallel matrix build tasks for amd64 and arm64 to two independent tasks.

@wuhuizuo
Copy link
Author

wuhuizuo commented Jul 6, 2024

have no time to finish the feature.

/unassign

@dorzel
Copy link

dorzel commented Apr 7, 2025

/assign dorzel

@dorzel
Copy link

dorzel commented Apr 7, 2025

Currently working on this in the linked PR, appreciate any feedback/suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants