Skip to content

Commit 42c4db7

Browse files
authored
Bug fix: fix --log-level help rendering (#951)
## What was changed Remove backticks that were causing broken `--help` rendering: **Before** Note spurious presence of "server start-dev" and lack of expected "string" ``` $ temporal --help | rg -C1 -F -- '--log-level' Log format. Accepted values: text, json. (default "text") --log-level server start-dev Log level. Default is "info" for most commands and "warn" ``` **After** ``` $ ./temporal --help | rg -C1 -F -- '--log-level' Log format. Accepted values: text, json. (default "text") --log-level string Log level. Default is "info" for most commands and "warn" ``` ## Why? Bug
1 parent f27f932 commit 42c4db7

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

cliext/flags.gen.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func (v *CommonOptions) BuildFlags(f *pflag.FlagSet) {
3939
f.BoolVar(&v.DisableConfigFile, "disable-config-file", false, "If set, disables loading environment config from config file. EXPERIMENTAL.")
4040
f.BoolVar(&v.DisableConfigEnv, "disable-config-env", false, "If set, disables loading environment config from environment variables. EXPERIMENTAL.")
4141
v.LogLevel = NewFlagStringEnum([]string{"debug", "info", "warn", "error", "never"}, "info")
42-
f.Var(&v.LogLevel, "log-level", "Log level. Default is \"info\" for most commands and \"warn\" for `server start-dev`. Accepted values: debug, info, warn, error, never.")
42+
f.Var(&v.LogLevel, "log-level", "Log level. Default is \"info\" for most commands and \"warn\" for \"server start-dev\". Accepted values: debug, info, warn, error, never.")
4343
v.LogFormat = NewFlagStringEnum([]string{"text", "json", "pretty"}, "text")
4444
f.Var(&v.LogFormat, "log-format", "Log format. Accepted values: text, json.")
4545
v.Output = NewFlagStringEnum([]string{"text", "json", "jsonl", "none"}, "text")

cliext/option-sets.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ option-sets:
5151
- never
5252
description: |
5353
Log level.
54-
Default is "info" for most commands and "warn" for `server start-dev`.
54+
Default is "info" for most commands and "warn" for "server start-dev".
5555
default: info
5656
- name: log-format
5757
type: string-enum

0 commit comments

Comments
 (0)