Skip to content

Commit 46203ac

Browse files
committed
cvsserver: use safe_pipe_capture for constant commands as well
This is not strictly necessary, but it is a good code hygiene. Signed-off-by: Junio C Hamano <[email protected]>
1 parent 27dd738 commit 46203ac

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

git-cvsserver.perl

+4-4
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ sub req_Root
356356
return 0;
357357
}
358358

359-
my @gitvars = `git config -l`;
359+
my @gitvars = safe_pipe_capture(qw(git config -l));
360360
if ($?) {
361361
print "E problems executing git-config on the server -- this is not a git repository or the PATH is not set correctly.\n";
362362
print "E \n";
@@ -943,7 +943,7 @@ sub req_co
943943

944944
# Provide list of modules, if -c was used.
945945
if (exists $state->{opt}{c}) {
946-
my $showref = `git show-ref --heads`;
946+
my $showref = safe_pipe_capture(qw(git show-ref --heads));
947947
for my $line (split '\n', $showref) {
948948
if ( $line =~ m% refs/heads/(.*)$% ) {
949949
print "M $1\t$1\n";
@@ -1181,7 +1181,7 @@ sub req_update
11811181
# projects (heads in this case) to checkout.
11821182
#
11831183
if ($state->{module} eq '') {
1184-
my $showref = `git show-ref --heads`;
1184+
my $showref = safe_pipe_capture(qw(git show-ref --heads));
11851185
print "E cvs update: Updating .\n";
11861186
for my $line (split '\n', $showref) {
11871187
if ( $line =~ m% refs/heads/(.*)$% ) {
@@ -1687,7 +1687,7 @@ sub req_ci
16871687
return;
16881688
}
16891689

1690-
my $treehash = `git write-tree`;
1690+
my $treehash = safe_pipe_capture(qw(git write-tree));
16911691
chomp $treehash;
16921692

16931693
$log->debug("Treehash : $treehash, Parenthash : $parenthash");

0 commit comments

Comments
 (0)