From 1986daa5634d1fde23997ecd7de1660a9babd427 Mon Sep 17 00:00:00 2001 From: Melissa Greenbaum <69476188+magreenbaum@users.noreply.github.com> Date: Thu, 7 Nov 2024 20:16:38 -0500 Subject: [PATCH] fix: Remove ACL in analytics, inventory, and replication examples (#292) --- examples/s3-analytics/main.tf | 4 ---- examples/s3-inventory/main.tf | 3 --- examples/s3-replication/main.tf | 3 --- 3 files changed, 10 deletions(-) diff --git a/examples/s3-analytics/main.tf b/examples/s3-analytics/main.tf index 50f6a12..5d71a72 100644 --- a/examples/s3-analytics/main.tf +++ b/examples/s3-analytics/main.tf @@ -24,7 +24,6 @@ module "analytics_configuration_bucket" { attach_analytics_destination_policy = true attach_policy = true analytics_self_source_destination = true - acl = "private" # "acl" conflicts with "grant" and "owner" versioning = { status = true @@ -77,7 +76,6 @@ module "analytics_destination_bucket" { source = "../../" bucket = "analytics-destination-${random_pet.this.id}" - acl = "private" # "acl" conflicts with "grant" and "owner" force_destroy = true attach_policy = true attach_analytics_destination_policy = true @@ -92,7 +90,6 @@ module "inventory_source_bucket" { bucket = "inventory-source-${random_pet.this.id}" force_destroy = true - acl = "private" # "acl" conflicts with "grant" and "owner" inventory_configuration = { destination_other = { @@ -115,7 +112,6 @@ module "analytics_and_inventory_destination_bucket" { source = "../../" bucket = "analytics-and-inventory-destination-${random_pet.this.id}" - acl = "private" # "acl" conflicts with "grant" and "owner" force_destroy = true attach_policy = true diff --git a/examples/s3-inventory/main.tf b/examples/s3-inventory/main.tf index 13cdeb0..eb91309 100644 --- a/examples/s3-inventory/main.tf +++ b/examples/s3-inventory/main.tf @@ -24,7 +24,6 @@ module "multi_inventory_configurations_bucket" { attach_policy = true attach_inventory_destination_policy = true inventory_self_source_destination = true - acl = "private" # "acl" conflicts with "grant" and "owner" versioning = { status = true @@ -137,7 +136,6 @@ module "inventory_destination_bucket" { source = "../../" bucket = "inventory-destination-${random_pet.this.id}" - acl = "private" # "acl" conflicts with "grant" and "owner" force_destroy = true attach_policy = true attach_inventory_destination_policy = true @@ -149,6 +147,5 @@ module "inventory_source_bucket" { source = "../../" bucket = "inventory-source-${random_pet.this.id}" - acl = "private" # "acl" conflicts with "grant" and "owner" force_destroy = true } diff --git a/examples/s3-replication/main.tf b/examples/s3-replication/main.tf index 4bdcded..857f404 100644 --- a/examples/s3-replication/main.tf +++ b/examples/s3-replication/main.tf @@ -16,7 +16,6 @@ provider "aws" { skip_metadata_api_check = true skip_region_validation = true skip_credentials_validation = true - skip_requesting_account_id = true } locals { @@ -47,7 +46,6 @@ module "replica_bucket" { } bucket = local.destination_bucket_name - acl = "private" versioning = { enabled = true @@ -58,7 +56,6 @@ module "s3_bucket" { source = "../../" bucket = local.bucket_name - acl = "private" versioning = { enabled = true