pull_subscriptions types for backoff should be string

[wrdls]

TL;DR

The type signature in "pull_subscriptions" for maximum_backoff and minimum_backoff should be optional(string) instead of optional(number).

This would align it with the other subscription types like push, bigquery, cloud_storage

This regression was introduced in #224

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

n/a

Terraform Version

n/a

Terraform Provider Versions

n/a

Additional information

No response

[craig-mulholland]

Just adding support for this as I have observed some strange behaviour due to this change. We use a for_each loop with the module which has been working as expected until I ran a job this week and it failed with this error:

The given value is not suitable for
--
4722 | module.pull_subscriptions["------***"].var.pull_subscriptions
4723 | declared at .terraform/modules/pull_subscriptions/variables.tf:66,1-30: a
4724 | number is required.
4725 |  
4726 | Error: Invalid value for input variable

This error is specific to the maximum / minimum backoff settings which when removed, allow the job to run normally. The module does work when not ran as part of a for_each loop and I haven't figured out specifically why it fails as part of the loop but forcing the module to use release 7.0.0 resolves the issue for now.

[apeabody]

Hi @ktinubu! Would you be able to open a PR to resolve? We can release as a patch fix v8.0.1.

CC: @q2w

[ktinubu]

@apeabody here's the PR. Thanks, @wrdls for raising this issue!