Skip to content

Commit c020da9

Browse files
authored
fix: fixed bug where the format of the config option in the topics input variable was incorrectly set to object({}). It is now correctly set to map(string).<br>### Upgrade note:<br> If upgrading from a previous version, an update in place will be done on the topic config. Previously the behaviour was:<br>- Topic is created without the values for the config, so the topic has the default config values<br>- Topic is upgraded with the config values, but because this was object({}) none of those were used, and the topic config is unchanged.<br><br> New behaviour:<br>- Topic is created without the values for the config and gets default values<br>- Topic is upgraded, and now because it's map(string) the properties are used, and the topic config changes (#343)
1 parent ffa36e7 commit c020da9

File tree

8 files changed

+8
-8
lines changed

8 files changed

+8
-8
lines changed

.secrets.baseline

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"files": "go.sum|^.secrets.baseline$",
44
"lines": null
55
},
6-
"generated_at": "2023-12-09T12:42:07Z",
6+
"generated_at": "2023-12-10T12:42:07Z",
77
"plugins_used": [
88
{
99
"name": "AWSKeyDetector"

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ You need the following permissions to run this module.
154154
| <a name="input_storage_size"></a> [storage\_size](#input\_storage\_size) | Storage size of the Event Streams in GB. Applies only to Enterprise plan instances. Possible values: `2048`, `4096`, `6144`, `8192`, `10240`, `12288`. Storage capacity cannot be reduced after the instance is created. When the `throughput` input variable is set to `300`, storage size starts at 4096. When `throughput` is `450`, storage size starts starts at `6144`. | `number` | `"2048"` | no |
155155
| <a name="input_tags"></a> [tags](#input\_tags) | The list of tags associated with the Event Steams instance. | `list(string)` | `[]` | no |
156156
| <a name="input_throughput"></a> [throughput](#input\_throughput) | Throughput capacity in MB per second. Applies only to Enterprise plan instances. Possible values: `150`, `300`, `450`. | `number` | `"150"` | no |
157-
| <a name="input_topics"></a> [topics](#input\_topics) | The list of topics to apply to resources. Only one topic is allowed for Lite plan instances. | <pre>list(object(<br/> {<br/> name = string<br/> partitions = number<br/> config = object({})<br/> }<br/> ))</pre> | `[]` | no |
157+
| <a name="input_topics"></a> [topics](#input\_topics) | The list of topics to apply to resources. Only one topic is allowed for Lite plan instances. | <pre>list(object(<br/> {<br/> name = string<br/> partitions = number<br/> config = map(string)<br/> }<br/> ))</pre> | `[]` | no |
158158
| <a name="input_update_timeout"></a> [update\_timeout](#input\_update\_timeout) | The timeout value for updating an Event Streams instance. Specify `1h` for an Enterprise plan instance. Add 1 h for each level of non-default throughput. A 30 min for each level of non-default storage size. | `string` | `"1h"` | no |
159159

160160
### Outputs

examples/complete/variables.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ variable "topics" {
7878
{
7979
name = string
8080
partitions = number
81-
config = object({})
81+
config = map(string)
8282
}
8383
))
8484
description = "The list of topics to apply to resources. Only one topic is allowed for Lite plan instances."

examples/fscloud/variables.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ variable "topics" {
4747
{
4848
name = string
4949
partitions = number
50-
config = object({})
50+
config = map(string)
5151
}
5252
))
5353
description = "List of topics. For lite plan only one topic is allowed."

modules/fscloud/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ No resources.
3939
| <a name="input_schemas"></a> [schemas](#input\_schemas) | The list of schema objects. Include the `schema_id` and the `type` and `name` of the schema in the `schema` object. | <pre>list(object(<br/> {<br/> schema_id = string<br/> schema = object({<br/> type = string<br/> name = string<br/> fields = optional(list(object({<br/> name = string<br/> type = string<br/> })))<br/> })<br/> }<br/> ))</pre> | `[]` | no |
4040
| <a name="input_service_credential_names"></a> [service\_credential\_names](#input\_service\_credential\_names) | The mapping of names and roles for service credentials that you want to create for the Event streams. | `map(string)` | `{}` | no |
4141
| <a name="input_tags"></a> [tags](#input\_tags) | The list of tags associated with the Event Steams instance. | `list(string)` | `[]` | no |
42-
| <a name="input_topics"></a> [topics](#input\_topics) | The list of topics to apply to resources. Only one topic is allowed for Lite plan instances. | <pre>list(object(<br/> {<br/> name = string<br/> partitions = number<br/> config = object({})<br/> }<br/> ))</pre> | `[]` | no |
42+
| <a name="input_topics"></a> [topics](#input\_topics) | The list of topics to apply to resources. Only one topic is allowed for Lite plan instances. | <pre>list(object(<br/> {<br/> name = string<br/> partitions = number<br/> config = map(string)<br/> }<br/> ))</pre> | `[]` | no |
4343

4444
### Outputs
4545

modules/fscloud/variables.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ variable "topics" {
5757
{
5858
name = string
5959
partitions = number
60-
config = object({})
60+
config = map(string)
6161
}
6262
))
6363
description = "The list of topics to apply to resources. Only one topic is allowed for Lite plan instances."

solutions/quickstart/variables.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ variable "topics" {
6161
{
6262
name = string
6363
partitions = number
64-
config = object({})
64+
config = map(string)
6565
}
6666
))
6767
description = "The list of topics to apply to resources. Only one topic is allowed for Lite plan instances. [Learn more](https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/tree/main/solutions/quickstart/DA-schemas-topics-cbr.md)."

variables.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ variable "topics" {
120120
{
121121
name = string
122122
partitions = number
123-
config = object({})
123+
config = map(string)
124124
}
125125
))
126126
description = "The list of topics to apply to resources. Only one topic is allowed for Lite plan instances."

0 commit comments

Comments
 (0)