Fix python3 filtering support.

* Test filtering was failing under python3 and would only apply the
  filters to the first test listed by discover. (Clark Boylan, #1317607)

Author: Clark Boylan

NEWS

@@ -11,6 +11,9 @@ CHANGES
 * ``run`` was outputting bad MIME types - test/plain, not text/plain.
   (Robert Collins)
 
+* Test filtering was failing under python3 and would only apply the
+  filters to the first test listed by discover. (Clark Boylan, #1317607)
+
 * When list-tests encounters an error, a much clearer response will
   now be shown. (Robert Collins, #1271133)
 

testrepository/testcommand.py

@@ -279,7 +279,7 @@ def filter_tests(self, test_ids):
         """
         if self.test_filters is None:
             return test_ids
-        filters = map(re.compile, self.test_filters)
+        filters = list(map(re.compile, self.test_filters))
         def include(test_id):
             for pred in filters:
                 if pred.search(test_id):

testrepository/tests/test_testcommand.py

@@ -575,3 +575,14 @@ def test_filter_tests_by_regex_supplied_ids(self):
         fixture = self.useFixture(command.get_run_command(
             test_ids=['return', 'of', 'the', 'king'], test_filters=filters))
         self.assertEqual(['return'], fixture.test_ids)
+
+    def test_filter_tests_by_regex_supplied_ids_multi_match(self):
+        ui, command = self.get_test_ui_and_cmd()
+        ui.proc_outputs = [_b('returned\nids\n')]
+        self.set_config(
+            '[DEFAULT]\ntest_command=foo $LISTOPT $IDLIST\ntest_id_list_default=whoo yea\n'
+            'test_list_option=--list\n')
+        filters = ['return']
+        fixture = self.useFixture(command.get_run_command(
+            test_ids=['return', 'of', 'the', 'king', 'thereisnoreturn'], test_filters=filters))
+        self.assertEqual(['return', 'thereisnoreturn'], fixture.test_ids)