You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs: remove use of spy to click an event in README.md (#184)
<!--
Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!
Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
Also, please make sure you're familiar with and follow the instructions in the
contributing guidelines (found in the CONTRIBUTING.md file).
If you're new to contributing to open source projects, you might find this free
video course helpful: http://kcd.im/pull-request
Please fill out the information below to expedite the review and (hopefully)
merge of your pull request!
-->
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
**What**: I replaced the spy and MouseEvent bubbling in the README.md
<!-- Why are these changes necessary? -->
**Why**: Handling clicks in this manner didn't work in my project, while `fireEvent.click(...)` did. Also a global search of this repo show the only instance of this handling occurring in the README.md
<!-- How were these changes implemented? -->
**How**:
<!-- Have you done all of these things? -->
**Checklist**:
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
- [ x] Documentation
- [ x] Tests
- [ x] Ready to be merged
<!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [ ] Added myself to contributors table
<!-- this is optional, see the contributing guidelines for instructions -->
<!-- feel free to add additional comments -->
If I'm wrong here, please tell me how. I'm new to open source and would like to learn. If I'm right, this one is such a gimme I feel I should earn a spot as a contributor with a separate task.
This library is awesome, keep up the great work!
0 commit comments