Skip to content

Commit fe3b65c

Browse files
just-borisKent C. Dodds
authored and
Kent C. Dodds
committed
fix: remove wait-for-expect from dependencies (#205)
**What**: Remove unused dependency from `package.json` **Why**: This package is not used here directly. Dom-testing-library uses it though and declares it there already: https://github.com/kentcdodds/dom-testing-library/blob/master/package.json#L43 On the other hand, in case if dom-testing-library would use a new major version of the dependency, there will be unwanted package duplication, because this line will stay. Packages should not declare dependencies on other packages, that they actually do not use. **Checklist**: - (N/A) Documentation - (N/A) Tests - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - (N/A) Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
1 parent 468223b commit fe3b65c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@
3737
"author": "Kent C. Dodds <[email protected]> (http://kentcdodds.com/)",
3838
"license": "MIT",
3939
"dependencies": {
40-
"dom-testing-library": "^3.9.0",
41-
"wait-for-expect": "^1.0.1"
40+
"dom-testing-library": "^3.9.0"
4241
},
4342
"devDependencies": {
4443
"@reach/router": "^1.2.1",

0 commit comments

Comments
 (0)