Skip to content

correct syntax errors in LSP section #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

correct syntax errors in LSP section #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2076,7 +2076,7 @@ class Square : Rectangle
}
}

Drawable RenderLargeRectangles(Rectangle rectangles)
Drawable RenderLargeRectangles(Rectangle[] rectangles)
{
foreach (rectangle in rectangles)
{
Expand All @@ -2094,7 +2094,7 @@ RenderLargeRectangles(rectangles);
**Good:**

```csharp
abstract class ShapeBase
abstract class RectangleBase
{
protected double Width = 0;
protected double Height = 0;
Expand All @@ -2107,7 +2107,7 @@ abstract class ShapeBase
}
}

class Rectangle : ShapeBase
class Rectangle : RectangleBase
{
public void SetWidth(double width)
{
Expand All @@ -2125,13 +2125,14 @@ class Rectangle : ShapeBase
}
}

class Square : ShapeBase
class Square : RectangleBase
{
private double Length = 0;

public double SetLength(double length)
{
Length = length;
Width = Height = lenght;
}

public double GetArea()
Expand All @@ -2140,7 +2141,7 @@ class Square : ShapeBase
}
}

Drawable RenderLargeRectangles(Rectangle rectangles)
Drawable RenderLargeRectangles(RectangleBase[] rectangles)
{
foreach (rectangle in rectangles)
{
Expand All @@ -2159,8 +2160,8 @@ Drawable RenderLargeRectangles(Rectangle rectangles)
}
}

var shapes = new[] { new Rectangle(), new Rectangle(), new Square() };
RenderLargeRectangles(shapes);
var rectangles = new[] { new Rectangle(), new Rectangle(), new Square() };
RenderLargeRectangles(rectangles);
```

**[⬆ back to top](#table-of-contents)**
Expand Down