Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Description Fields not saving when editing other item fields. #211

Open
1 task done
LLilliputian opened this issue Feb 1, 2025 · 3 comments
Open
1 task done
Assignees
Labels
Enhancement Improvements not directly related to features/bugs good first issue Good for newcomers ui User interface related issue ux User experience related issue
Milestone

Comments

@LLilliputian
Copy link
Contributor

Describe the bug
When editing description and switching to another tab when you switch back description editing screen remains open and is reset to whatever it was before starting editing. So items that had descriptions already go back to its prior description and new items go back to blank.

To Reproduce
Steps to reproduce the behavior:

  1. Open Any time, new or already created. (I tried several types like equipment/power/loot and it had the same effect.
  2. Edit Description.
  3. Update any other field in the item IE: title, details, effects, etc

Expected behavior
Description should leave edit mode

Screenshots
https://github.com/user-attachments/assets/3d18664d-b4a2-45b7-a3f7-421ac4762032

Foundry VTT Version
Not mentioned by reporter

Cosmere RPG System Version
0.2.2

Browser
Accessed through browser and only seems to show up when on hosted browser rather than a local foundry instance

Additional context
Add any other context about the problem here.

Checklist:

  • I have searched the existing issues to ensure this bug has not already been reported
@LLilliputian LLilliputian added the bug Something isn't working label Feb 1, 2025
@LLilliputian
Copy link
Contributor Author

Planning on taking a look into this if nobody else has started yet

@zithith zithith added Enhancement Improvements not directly related to features/bugs good first issue Good for newcomers ui User interface related issue ux User experience related issue and removed bug Something isn't working labels Feb 8, 2025
@zithith zithith added this to the Release 1.0.0 milestone Feb 8, 2025
@Doc-Sun
Copy link
Contributor

Doc-Sun commented Feb 9, 2025

Just a heads up as I experienced this more. It seems to have odd effects using the html section as if you try and hit save it clears, in this instance you have to click the html edit again to go back THEN save.

@LLilliputian
Copy link
Contributor Author

LLilliputian commented Feb 11, 2025

Thanks Doc think that should be solved by my changes so far but will make sure to double check.

I've got it set up at the moment so when you switch tabs it will return to the full description screen without having saved changes.
Issue I'm having at the moment is when editing the description and the changing the item name it returns to the full description screen but saves the changes that have been made while editing.
I just wanted to confirm I'm remembering right than in both cases we don't want to save any changes that have been made to the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements not directly related to features/bugs good first issue Good for newcomers ui User interface related issue ux User experience related issue
Projects
None yet
Development

No branches or pull requests

3 participants