Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(actor): implement damage and condition immunities #227

Draft
wants to merge 4 commits into
base: release-0.3.0
Choose a base branch
from
Draft

feat(actor): implement damage and condition immunities #227

wants to merge 4 commits into from

Conversation

stanavdb
Copy link
Collaborator

@stanavdb stanavdb commented Feb 9, 2025

Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)

  • Bug fix
  • Feature
  • Refactor
  • Other (please describe):

Description
This PR adds damage and condition immunities to actors.

Related Issue
Closes #224

How Has This Been Tested?
Describe how you tested the changes and how others can replicate the testing steps.

Screenshots (if applicable)
image

Checklist:

  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce any new warnings or errors.
  • My PR does not contain any copyrighted works that I do not have permission to use.
  • I have tested my changes on Foundry VTT version: [insert version here].

@stanavdb stanavdb self-assigned this Feb 9, 2025
@stanavdb
Copy link
Collaborator Author

stanavdb commented Feb 9, 2025 •
edited
Loading

@MangoFVTT Do you want me to add configuration options for these to the sheets (character & adversary), or leave that all up to you?

@zithith zithith linked an issue Feb 9, 2025 that may be closed by this pull request
Implement Immunities #224
Open
1 task
zithith
zithith previously approved these changes Feb 9, 2025
View reviewed changes
@zithith
Copy link
Contributor

zithith commented Feb 9, 2025

We could sub-issue this ticket again, make this implement the dice logic and then another that implements the configuration of immunities from the character sheet?

@stanavdb
Copy link
Collaborator Author

We could sub-issue this ticket again, make this implement the dice logic and then another that implements the configuration of immunities from the character sheet?

That seems excessive to me. This PR isn't too large yet, let's have this implement the full feature.

@MangoFVTT
Copy link
Contributor

MangoFVTT commented Feb 21, 2025 •
edited
Loading

@stanavdb now that the general sheet styling is merged, it should be quite simple to implement a dialog to configure immunities by ripping the Expertises dialog template and using the same setup to get a fully styled dialog. Let me know if you need me to give it a once over styling wise.

As far as were I should put it, I think the best option is to have an Immunities section below Expertises that also uses the same layout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zithith zithith zithith left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@stanavdb stanavdb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Immunities
3 participants
@stanavdb @zithith @MangoFVTT