feat(migration): enable automatic data migrations between versions #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zithith
reviewed
Feb 19, 2025
There was a problem hiding this comment.
I think I'll leave the Talent Tree sign-off to @stanavdb, though to me it looks about right.
But one other point (plus my comment on the character migration script): Do we want to add a method to call this manually from somewhere? may not be one for implementing this ticket, but food for thought...
| // ), | ||
| // ); | ||
| // } | ||
|
|
There was a problem hiding this comment.
Also needs a level value change, previously it was typed as string I think? but now that the advancement is in it's a number.
Can see examples of this with the B9 pregens
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)
Description
This PR establishes an automatic method for performing data migrations, for cases where breaking changes are introduced to the model between versions. It automatically checks for all migrations between the last known system version in the given world and the new version of the system, and attempts to convert the previous data to the known schema from that version.
To-Do List
Related Issue
Closes #244
How Has This Been Tested?
Checklist:
Additional Context:
The bulk of this PR is based on Stan's blueprint. It has largely been updated to be type-safe and functional with the latest changes to the data model, especially following the changes to talent trees.