Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Roll Data with Equipment Info and Roll Source #271

Open
1 task done
Khunkurisu opened this issue Feb 20, 2025 · 1 comment
Open
1 task done

Expand Roll Data with Equipment Info and Roll Source #271

Khunkurisu opened this issue Feb 20, 2025 · 1 comment
Labels
api dice calculation Enhancement Improvements not directly related to features/bugs ux User experience related issue
Milestone

Comments

@Khunkurisu
Copy link

Is your feature request related to a problem? Please describe.
A lot of abilities modify the damage of specific types of attacks or rolls under certain circumstances. Currently we have no way to differentiate different rolls.

Describe the solution you'd like
Include information from equipped weapons and armor in the metadata of a roll, along with the source of the roll (weapon, skill test, talent). Add a 'modifiers' object to the actor data model with keys for common triggers (ranged-attack, strike-damage, cognitive-skill, etc) so they can be modified by Active Effects. Apply the modifiers from this object when their key matches the predicate information provided to a roll.

Describe alternatives you've considered
None of this is necessary and may cross the line for automation provided by the system officially. At the very least, hooks for modules to add such things to the system should be considered if not supporting this functionality outright.

Version
0.3.0

Additional context
This is most likely post-1.0 functionality.

Checklist:

  • I have searched the existing issues to ensure this feature has not already been requested.
@zithith zithith added this to the post v1 milestone Feb 20, 2025
@zithith zithith added ux User experience related issue api Enhancement Improvements not directly related to features/bugs dice calculation labels Feb 20, 2025
@zithith
Copy link
Contributor

zithith commented Feb 20, 2025

mildly related: Code Comment I added in a while ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api dice calculation Enhancement Improvements not directly related to features/bugs ux User experience related issue
Projects
None yet
Development

No branches or pull requests

2 participants