Skip to content

Commit f827e15

Browse files
committed
refactor: remove straggling boost::mutex usage
After the merge of bitcoin#18710, the linter is warning: ```bash A new Boost dependency in the form of "boost/thread/mutex.hpp" appears to have been introduced: src/sync.cpp:#include <boost/thread/mutex.hpp> src/test/sync_tests.cpp:#include <boost/thread/mutex.hpp> ^---- failure generated from test/lint/lint-includes.sh ``` the interim bitcoin#19337 was merged, which introduced more `boost::mutex` usage. Given we no longer use `boost::mutex`, just remove the double lock test and remaining includes.
1 parent 16ae336 commit f827e15

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

src/sync.cpp

-3
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
#include <util/strencodings.h>
1414
#include <util/threadnames.h>
1515

16-
#include <boost/thread/mutex.hpp>
17-
1816
#include <map>
1917
#include <mutex>
2018
#include <set>
@@ -224,7 +222,6 @@ template void EnterCritical(const char*, const char*, int, Mutex*, bool);
224222
template void EnterCritical(const char*, const char*, int, RecursiveMutex*, bool);
225223
template void EnterCritical(const char*, const char*, int, std::mutex*, bool);
226224
template void EnterCritical(const char*, const char*, int, std::recursive_mutex*, bool);
227-
template void EnterCritical(const char*, const char*, int, boost::mutex*, bool);
228225

229226
void CheckLastCritical(void* cs, std::string& lockname, const char* guardname, const char* file, int line)
230227
{

src/test/sync_tests.cpp

-6
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
#include <test/util/setup_common.h>
77

88
#include <boost/test/unit_test.hpp>
9-
#include <boost/thread/mutex.hpp>
109

1110
#include <mutex>
1211

@@ -110,11 +109,6 @@ BOOST_AUTO_TEST_CASE(double_lock_mutex)
110109
TestDoubleLock<Mutex>(true /* should throw */);
111110
}
112111

113-
BOOST_AUTO_TEST_CASE(double_lock_boost_mutex)
114-
{
115-
TestDoubleLock<boost::mutex>(true /* should throw */);
116-
}
117-
118112
BOOST_AUTO_TEST_CASE(double_lock_recursive_mutex)
119113
{
120114
TestDoubleLock<RecursiveMutex>(false /* should not throw */);

0 commit comments

Comments
 (0)