Skip to content

Commit 5ea1e76

Browse files
authored
Don't try to use the activity bar if it isn't enabled (#63)
Fixes #59
1 parent 02b699b commit 5ea1e76

2 files changed

Lines changed: 16 additions & 2 deletions

File tree

‎debug/embedded.html‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,17 @@
2626
nulla pariatur. Excepteur sint occaecat cupidatat non proident,
2727
sunt in culpa qui officia deserunt mollit anim id est laborum.
2828
</p>
29+
<kicanvas-embed src="examples/pins.kicad_sch" controls="basic">
30+
</kicanvas-embed>
31+
<p>
32+
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do
33+
eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut
34+
enim ad minim veniam, quis nostrud exercitation ullamco laboris
35+
nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor
36+
in reprehenderit in voluptate velit esse cillum dolore eu fugiat
37+
nulla pariatur. Excepteur sint occaecat cupidatat non proident,
38+
sunt in culpa qui officia deserunt mollit anim id est laborum.
39+
</p>
2940
<kicanvas-embed src="examples/starfish.kicad_pcb" controls="full">
3041
</kicanvas-embed>
3142
<p>

‎src/kicanvas/elements/common/app.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export abstract class KCViewerAppElement<
4141
ViewerElementT extends ViewerElement,
4242
> extends KCUIElement {
4343
#viewer_elm: ViewerElementT;
44-
#activity_bar: KCUIActivitySideBarElement;
44+
#activity_bar: KCUIActivitySideBarElement | null;
4545

4646
project: Project;
4747
viewerReady: DeferredPromise<boolean> = new DeferredPromise<boolean>();
@@ -180,7 +180,7 @@ export abstract class KCViewerAppElement<
180180
protected abstract make_activities(): ElementOrFragment[];
181181

182182
protected change_activity(name?: string) {
183-
this.#activity_bar.change_activity(name);
183+
this.#activity_bar?.change_activity(name);
184184
}
185185

186186
protected abstract make_viewer_element(): ViewerElementT;
@@ -208,6 +208,9 @@ export abstract class KCViewerAppElement<
208208
${pre_activities} ${activities} ${post_activities}
209209
</kc-ui-activity-side-bar>` as KCUIActivitySideBarElement;
210210
resizer = html`<kc-ui-resizer></kc-ui-resizer>`;
211+
} else {
212+
// NO activity bar
213+
this.#activity_bar = null;
211214
}
212215

213216
const top_toolbar_buttons = [];

0 commit comments

Comments
 (0)