Skip to content

Commit f482e6a

Browse files
authored
fix: #1803 cleanups for noUnusedLocals and noUnusedParameters (#1804)
* fix: #1803 * fix: update
1 parent b92b049 commit f482e6a

File tree

122 files changed

+125
-347
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

122 files changed

+125
-347
lines changed

src/lib/alert/Alert.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
2626
let ref: HTMLDivElement | undefined = $state(undefined);
2727
28-
function close(event: MouseEvent) {
28+
function close() {
2929
if (ref?.dispatchEvent(new Event("close", { bubbles: true, cancelable: true }))) {
3030
alertStatus = false;
3131
}

src/lib/badge/Badge.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
2121
let ref: HTMLDivElement | undefined = $state(undefined);
2222
23-
const close = (ev: Event) => {
23+
const close = () => {
2424
if (ref?.dispatchEvent(new Event("close", { bubbles: true, cancelable: true }))) {
2525
badgeStatus = false;
2626
}

src/lib/carousel/Carousel.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
const nextSlide = () => changeSlide(_state.index + 1);
5858
const prevSlide = () => changeSlide(_state.index - 1);
5959
60-
const loop = (node: HTMLElement) => {
60+
const loop = () => {
6161
// loop timer
6262
/* eslint-disable @typescript-eslint/no-explicit-any */
6363
let intervalId: any;
@@ -127,7 +127,7 @@
127127
let onDragStop = $derived(
128128
activeDragGesture === undefined
129129
? undefined
130-
: (evt: MouseEvent | TouchEvent) => {
130+
: () => {
131131
// These might be exposed one day, keep them safely tucked away as constants.
132132
const SWIPE_MAX_DURATION = 250;
133133
const SWIPE_MIN_DISTANCE = 30;

src/lib/dialog/Dialog.svelte

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
1515
let { base, form: formCls, close: closeCls } = dialog();
1616
17-
const close = (dlg: HTMLDialogElement) => (open = false);
17+
const close = () => (open = false);
1818
1919
// Prefer requestClose when available to trigger a cancellable "cancel" event; otherwise synthesize it.
2020
const cancel = (dlg: HTMLDialogElement) => {
@@ -34,7 +34,7 @@
3434
if (ev.defaultPrevented) return;
3535
3636
ev.preventDefault(); // prevent anyway, we need clean close
37-
if (!permanent) close(ev.currentTarget);
37+
if (!permanent) close();
3838
}
3939
4040
function _onclick(ev: MouseEvent & { currentTarget: HTMLDialogElement }) {
@@ -50,7 +50,7 @@
5050
}
5151
5252
if (autoclose && ev.target instanceof HTMLButtonElement && !permanent) {
53-
return close(dlg);
53+
return close();
5454
}
5555
}
5656
@@ -82,7 +82,7 @@
8282
if (result === false) return;
8383
}
8484
85-
close(dlg);
85+
close();
8686
}
8787
8888
function _ontoggle(ev: ToggleEvent & { currentTarget: HTMLDialogElement }) {
@@ -112,7 +112,7 @@
112112
113113
let ref: HTMLDialogElement | undefined = $state(undefined);
114114
115-
function close_handler(ev: MouseEvent) {
115+
function close_handler() {
116116
if (form) {
117117
// dialog/form mechanism will close the dialog
118118
return;

src/lib/forms/input-field/Input.svelte

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
}
104104
});
105105
106-
function defaultHandleInput(event: Event) {
106+
function defaultHandleInput(_event: Event) {
107107
// Ensure value is treated as a string to safely check its length
108108
const currentValueAsString = String(value || "");
109109
if (currentValueAsString.length > 0) {
@@ -112,12 +112,12 @@
112112
updateSuggestions();
113113
}
114114
115-
function defaultHandleFocus(event: FocusEvent) {
115+
function defaultHandleFocus() {
116116
isFocused = true;
117117
updateSuggestions();
118118
}
119119
120-
function defaultHandleBlur(event: FocusEvent) {
120+
function defaultHandleBlur() {
121121
// Small delay to allow click on suggestion to fire first
122122
setTimeout(() => {
123123
isFocused = false;
@@ -174,14 +174,14 @@
174174
if (resolvedOnFocus) {
175175
resolvedOnFocus(event);
176176
}
177-
defaultHandleFocus(event);
177+
defaultHandleFocus();
178178
}
179179
180180
function handleBlur(event: FocusEvent) {
181181
if (resolvedOnBlur) {
182182
resolvedOnBlur(event);
183183
}
184-
defaultHandleBlur(event);
184+
defaultHandleBlur();
185185
}
186186
187187
function handleKeydown(event: KeyboardEvent) {

src/lib/forms/tags/Tags.svelte

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@
5151
});
5252
}
5353
54-
const checkDropdownPosition = () => {
55-
if (!inputContainer) return;
56-
};
57-
5854
const handleKeys = (event: KeyboardEvent) => {
5955
if (event.key === "Enter") {
6056
event.preventDefault();
@@ -102,10 +98,6 @@
10298
}
10399
};
104100
105-
const handleInput = () => {
106-
checkDropdownPosition();
107-
};
108-
109101
const deleteField = (index: number) => {
110102
value = value.filter((_, i) => i !== index);
111103
errorMessage = "";
@@ -135,7 +127,7 @@
135127
});
136128
</script>
137129

138-
<svelte:window on:scroll={checkDropdownPosition} on:resize={checkDropdownPosition} />
130+
<svelte:window />
139131

140132
{#if showAvailableTags && availableTags.length > 0}
141133
<P class={clsx(info(), classes?.info)}>Available tags: {availableTags.join(", ")}</P>
@@ -149,6 +141,10 @@
149141
{/if}
150142
{/if}
151143

144+
{#if errorMessage}
145+
<P class={clsx(error(), classes?.error)}>{errorMessage}</P>
146+
{/if}
147+
152148
<div
153149
{...restProps}
154150
class={base({
@@ -164,7 +160,7 @@
164160
</div>
165161
{/each}
166162
<div class="relative w-full" bind:this={inputContainer}>
167-
<input {...inputProps} {disabled} bind:this={inputElement} onkeydown={handleKeys} oninput={handleInput} bind:value={contents} placeholder={value.length === 0 ? placeholder : ""} type="text" autocomplete="off" class={inputCls({ class: clsx(styling.input) })} />
163+
<input {...inputProps} {disabled} bind:this={inputElement} onkeydown={handleKeys} bind:value={contents} placeholder={value.length === 0 ? placeholder : ""} type="text" autocomplete="off" class={inputCls({ class: clsx(styling.input) })} />
168164
{#if availableTags.length > 0 && contents.trim() !== ""}
169165
{@const filteredSuggestions = availableTags.filter((tag) => tag.toLowerCase().includes(contents.trim().toLowerCase()) && (!unique || !value.some((t) => t.toLowerCase() === tag.toLowerCase())))}
170166
{#if filteredSuggestions.length > 0}

src/lib/forms/timepicker/Timepicker.svelte

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
2323
// State
2424
let selectedOption = $state("");
25-
let dropdownOpen = $state(false);
2625
let showTimerange = $state(false);
2726
2827
// Helper functions using date-fns
@@ -117,7 +116,6 @@
117116
}
118117
119118
function handleDropdownSelect(option: TimePickerOption): void {
120-
dropdownOpen = false;
121119
selectedOption = option.value;
122120
notifyChange();
123121
}
@@ -133,7 +131,6 @@
133131
}
134132
135133
function applyTimerange(): void {
136-
dropdownOpen = false;
137134
notifyChange();
138135
}
139136

src/lib/mega-menu/MegaMenu.svelte

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<script lang="ts">
22
import { megamenu } from "./theme";
33
import clsx from "clsx";
4-
import type { MegaMenuProps, LinkType } from "$lib";
4+
import type { MegaMenuProps } from "$lib";
55
import Popper from "$lib/utils/Popper.svelte";
66
import { getTheme, warnThemeDeprecation } from "$lib/theme/themeUtils";
77
@@ -10,14 +10,7 @@
1010
// ulClass, extraClass
1111
warnThemeDeprecation("MegaMenu", { ulClass, extraClass }, { ulClass: "ul", extraClass: "extra" });
1212
const styling = $derived(classes ?? { ul: ulClass, extra: extraClass });
13-
1413
const theme = getTheme("megamenu");
15-
16-
/* eslint-disable @typescript-eslint/no-explicit-any */
17-
interface LinkTypeLike extends LinkType {
18-
[propName: string]: any;
19-
}
20-
2114
const { base, div, ul, extra: extraCls } = $derived(megamenu({ full, hasExtra: !!extra }));
2215
</script>
2316

src/lib/navbar/NavHamburger.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
const navBreakpoint = getContext<NavbarBreakpoint>("breakpoint");
1919
const { base, menu } = navbarHamburger({ breakpoint: navBreakpoint });
2020
21-
const toggle: MouseEventHandler<HTMLButtonElement> = (ev) => {
21+
const toggle: MouseEventHandler<HTMLButtonElement> = () => {
2222
navState.hidden = !navState.hidden;
2323
};
2424
</script>

src/lib/rating/Review.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import type { ReviewProps } from "$lib/types";
55
import { getTheme, warnThemeDeprecation } from "$lib/theme/themeUtils";
66
7-
let { children, address, item1, item2, item3, review, class: className, classes, articleClass, divClass, div2Class, div3Class, imgClass, ulClass, liClass }: ReviewProps = $props();
7+
let { children, address, item1, item2, item3, review, classes, articleClass, divClass, div2Class, div3Class, imgClass, ulClass, liClass }: ReviewProps = $props();
88
99
warnThemeDeprecation("Review", { articleClass, divClass, div2Class, div3Class, imgClass, ulClass, liClass }, { articleClass: "article", divClass: "div", div2Class: "div2", div3Class: "div3", imgClass: "img", ulClass: "ul", liClass: "li" });
1010
const styling = $derived(

0 commit comments

Comments
 (0)