Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-next-version can't handle a commit tagged with multiple version granularity tags #135

Open
duckpuppy opened this issue Aug 14, 2024 · 1 comment

Comments

@duckpuppy
Copy link

What happened incorrectly?

A git commit tagged with, for example, v4, v4.5, and v4.5.14 results in get-next-version complaining that the commit is tagged with multiple semver versions. This tagging format is common in some workflows to always point to the most recent v4 release or v4.5 minor release sequence in addition to the specific release commit.

What should have happened instead?

get-next-version should use only the actual semver formatted tag (the one with all version elements) to calculate the next version.

What steps are needed to reproduce the bug?

  • Tag a commit with tags in the format v<major>, v<major>.<minor> and v<major>.<minor>.<patch>
  • run get-next-commit and see the error.
@goloroden
Copy link
Member

Thanks for bringing up this issue.

Since we do not use these shortened version numbers in our processes, we are not planning to implement this.

However, if you come up with a PR, we would be happy to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants