Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'disconnect' event for dynamodb repository not working #62

Open
elmolicious opened this issue Sep 13, 2017 · 2 comments
Open

'disconnect' event for dynamodb repository not working #62

elmolicious opened this issue Sep 13, 2017 · 2 comments

Comments

@elmolicious
Copy link

Hi,

We are currently implementing the denormalizer with the dynamodb repository and it seems like the 'disconnect' event does not get emitted.

I tested it by setting up a docker-compose with my service (using the denormalizer) and dynamodb and simply stopped the dynamodb container while the service was still running.

Can someone confirm that this is a problem with dynamodb? or is it a general problem?

Thanks for the answers in advance

@adrai
Copy link
Contributor

adrai commented Sep 13, 2017

this is not a general problem... but in real life I think dynamodb as a service offering will not go down that easy...
I think the aws sdk has no sort of disconnect event for dynamodb...

@elmolicious
Copy link
Author

Ok you are right, I guess the aws-sdk is stateless (no open connection, each request is a new, fresh one) and the concept of connection-lifecycle-hooks ('connect' and 'disconnect' events) does not really work with dynamodb.

Maybe it would be a good idea to enhance the existing documentation and add a notifier that the connection events are not supported when working with dynamodb as the repository type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants