slice off backpack items if char has no backpack#2
Open
tischepe wants to merge 1 commit intothestdman:masterfrom
Open
slice off backpack items if char has no backpack#2tischepe wants to merge 1 commit intothestdman:masterfrom
tischepe wants to merge 1 commit intothestdman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that the backpack empty space count is not always correct,
The rotmg server returns this:
<Char id="***">
<ObjectType>782</ObjectType>
<Level>20</Level>
<Exp>154063</Exp>
<CurrentFame>261</CurrentFame>
<Equipment>2719,2774,2656,2755,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1</Equipment>
... snip ...
<HasBackpack>0</HasBackpack>
</Char>
The character has no backpack, yet equipment contains 19 items, these 7 nonexistent empty spaces get counted in totals.
So I slice the array if the char has no backpack before pushing it into items.