refactor: apply Interface Segregation to TUnitServiceProvider#4939
Closed
thomhurst wants to merge 1 commit into
Closed
refactor: apply Interface Segregation to TUnitServiceProvider#4939thomhurst wants to merge 1 commit into
thomhurst wants to merge 1 commit into
Conversation
Extract three focused interfaces from TUnitServiceProvider to allow consumers to depend only on the services they actually need: - ITestDiscoveryServices: DiscoveryService, TestBuilderPipeline, TestFilterService, TestFinder - ITestExecutionServices: TestExecutor, TestSessionCoordinator, CancellationToken, FailFastCancellationSource, AfterSessionHooksFailed - ILoggingServices: Logger, VerbosityService, MessageBus Update consumers: - TestSessionCoordinator now depends on ITestExecutionServices - TestRequestHandler/IRequestHandler now accept the specific interfaces - TUnitTestFramework passes serviceProvider (which implements all three)
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a clean, well-executed Interface Segregation refactor. A few notes worth calling out: What's done well:
One design note (not a blocker): Overall, this is a solid first step in the incremental ISP migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #4898 -
TUnitServiceProviderexposes 35+ public properties, violating the Interface Segregation Principle.TUnitServiceProviderso consumers depend only on the services they actually need:ITestDiscoveryServices:DiscoveryService,TestBuilderPipeline,TestFilterService,TestFinderITestExecutionServices:TestExecutor,TestSessionCoordinator,CancellationToken,FailFastCancellationSource,AfterSessionHooksFailedILoggingServices:Logger,VerbosityService,MessageBusTestSessionCoordinatorto depend onITestExecutionServicesinstead of the fullTUnitServiceProviderIRequestHandlerandTestRequestHandlerto accept the specific interfaces they needTUnitServiceProviderimplements all three interfaces, soTUnitTestFrameworkcan pass it directlyThis is an incremental first step -- further consumers and properties can be migrated to narrower interfaces in follow-up work.
Test plan
dotnet build TUnit.Engine/TUnit.Engine.csprojpasses with zero errors and zero warnings