Skip to content

Commit f6996df

Browse files
authored
Merge pull request #149 from threshold-network/split-api-docs-to-multiple-files
Split contracts API doc into multiple files Having all the contracts documented in one common file turned out to be hard to render by the GitBook. We're switching to documenting each contract file in a separate Markdown file. As the generated files will be much smaller now and GitBook has its own file ON THIS PAGE section, we don't need to generate Table of Contents. The one thing that we also change as part of this PR is rsyncDelete setting - we'll have it set to true, in order to delete documentation of contracts which get removed from the repo. As we're not working directly on a main branch, this isn't dangerous (we'll see all the deletions in the PR diff). As part of this PR we also unify the naming convention for the YAML files - we want to use .yml everywhere. With .yaml used in contracts-docs workflow, the filter job was misconfigured.
2 parents c9091e9 + 24f5c2f commit f6996df

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

.github/workflows/contracts-docs.yaml renamed to .github/workflows/contracts-docs.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
uses: keep-network/ci/.github/workflows/reusable-solidity-docs.yml@main
4343
with:
4444
publish: false
45+
addTOC: false
4546
commentPR: true
4647
exportAsGHArtifacts: true
4748

@@ -58,12 +59,14 @@ jobs:
5859
uses: keep-network/ci/.github/workflows/reusable-solidity-docs.yml@main
5960
with:
6061
publish: true
62+
addTOC: false
6163
verifyCommits: true
6264
destinationRepo: threshold-network/threshold
6365
destinationFolder: ./docs/app-development/staking-contract-and-dao/staking-contract-and-dao-api
6466
destinationBaseBranch: main
6567
userEmail: [email protected]
6668
userName: Valkyrie
69+
rsyncDelete: true
6770
secrets:
6871
githubToken: ${{ secrets.THRESHOLD_DOCS_GITHUB_TOKEN }}
6972
gpgPrivateKey: ${{ secrets.THRESHOLD_DOCS_GPG_PRIVATE_KEY_BASE64 }}
File renamed without changes.
File renamed without changes.

hardhat.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ const config: HardhatUserConfig = {
124124
docgen: {
125125
outputDir: "generated-docs",
126126
templates: "docgen-templates",
127-
pages: "single", // `single`, `items` or `files`
127+
pages: "files", // `single`, `items` or `files`
128128
exclude: ["./test"],
129129
},
130130
}

0 commit comments

Comments
 (0)