Return EFI_NOT_FOUND for NULL SourceBuffer and DevicePath in LoadImage#12565
Open
MontyZhaoo wants to merge 1 commit into
Open
Return EFI_NOT_FOUND for NULL SourceBuffer and DevicePath in LoadImage#12565MontyZhaoo wants to merge 1 commit into
MontyZhaoo wants to merge 1 commit into
Conversation
…NULL Update CoreLoadImageCommon to return EFI_NOT_FOUND instead of EFI_INVALID_PARAMETER when both SourceBuffer and DevicePath are NULL. UEFI 2.11 specification requires this change for LoadImage(). Signed-off-by: jie.fu <jie.fu@cixtech.com>
tianocore-assign-reviewers
Bot
requested review from
khaliid2040,
lgao4 and
mikebeaton
mikebeaton
approved these changes
May 11, 2026
Member
mikebeaton
left a comment
mikebeaton
left a comment
There was a problem hiding this comment.
Indeed appears to match current spec. and changes made elsewhere.
khaliid2040
approved these changes
May 11, 2026
Author
|
@lgao4 Hi, when you get a chance, could you take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update CoreLoadImageCommon to return EFI_NOT_FOUND instead of EFI_INVALID_PARAMETER when both SourceBuffer and DevicePath are NULL. UEFI 2.11 specification requires this change for LoadImage().
UEFI Spec
SCT update patch
How This Was Tested
Successfully passed the Arm SystemReady SCT (Self-Certification Test) suite.
BS.LoadImage - ConsistencyTestCheckpoint2.