Skip to content

Commit bea062d

Browse files
authored
Fixes #1309 (#1310)
* Switches `object` with `x` for prediction argument in decision tree functions * Adds news item, bumps version
1 parent 86589b1 commit bea062d

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: parsnip
22
Title: A Common API to Modeling and Analysis Functions
3-
Version: 1.3.3.9000
3+
Version: 1.3.3.9001
44
Authors@R: c(
55
person("Max", "Kuhn", , "[email protected]", role = c("aut", "cre")),
66
person("Davis", "Vaughan", , "[email protected]", role = "aut"),

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# parsnip (development version)
22

3+
* Fixes issue with running predictions for Decision Trees in Spark (#1309)
4+
35
* Updates to some boosting tuning parameter information: (#1306)
46
- lightgbm and catboost have smaller default ranges for the learning rate: -3 to -1 / 2 in log10 units.
57
- lightgbm, xgboost, catboost, and C5.0 have smaller default ranges for the sampling proportion: 0.5 to 1.0.

R/decision_tree_data.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ set_pred(
325325
pre = NULL,
326326
post = format_spark_num,
327327
func = c(pkg = "sparklyr", fun = "ml_predict"),
328-
args = list(object = quote(object$fit), dataset = quote(new_data))
328+
args = list(x = quote(object$fit), dataset = quote(new_data))
329329
)
330330
)
331331

@@ -338,7 +338,7 @@ set_pred(
338338
pre = NULL,
339339
post = format_spark_class,
340340
func = c(pkg = "sparklyr", fun = "ml_predict"),
341-
args = list(object = quote(object$fit), dataset = quote(new_data))
341+
args = list(x = quote(object$fit), dataset = quote(new_data))
342342
)
343343
)
344344

@@ -351,6 +351,6 @@ set_pred(
351351
pre = NULL,
352352
post = format_spark_probs,
353353
func = c(pkg = "sparklyr", fun = "ml_predict"),
354-
args = list(object = quote(object$fit), dataset = quote(new_data))
354+
args = list(x = quote(object$fit), dataset = quote(new_data))
355355
)
356356
)

0 commit comments

Comments
 (0)