clean up .onLoad() (#7034)

* clean up .onLoad()

.onLoad() seemed to be setting dplyr.show_progress in a users
options which didn't seem neccessary. This removes that and
maintains current logic (although AFAICT progress bars have
been deprecated anyway).

* Explicitly set `default = TRUE`

---------

Co-authored-by: Davis Vaughan <[email protected]>

Author: TimTaylor

R/progress.R

@@ -108,7 +108,7 @@ Progress <- R6::R6Class(
 
     print = function(...) {
       if (
-        !isTRUE(getOption("dplyr.show_progress")) || # user specifies no progress
+        isFALSE(getOption("dplyr.show_progress", default = TRUE)) || # user specifies no progress
           !interactive() || # not an interactive session
           !is.null(getOption("knitr.in.progress")) # dplyr used within knitr document
       ) {

R/zzz.R

@@ -1,15 +1,6 @@
 .onLoad <- function(libname, pkgname) {
   ns_dplyr <- ns_env(pkgname)
 
-  op <- options()
-  op.dplyr <- list(
-    dplyr.show_progress = TRUE
-  )
-  toset <- !(names(op.dplyr) %in% names(op))
-  if (any(toset)) {
-    options(op.dplyr[toset])
-  }
-
   .Call(dplyr_init_library, ns_dplyr, ns_env("vctrs"), ns_env("rlang"))
 
   # TODO: For `arrange()`, `group_by()`, `with_order()`, and `nth()` until vctrs