Skip to content

Commit 11679cd

Browse files
committed
Fix proto link
1 parent a6494bf commit 11679cd

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

cran-comments.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
This is a resubmission, using the canonical link to the proto package.
2+
3+
---
4+
15
## Test environments
26
* OS X, R 3.2.2
37
* Ubuntu 14.04, R 3.2.2

vignettes/extending-ggplot2.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ As you read this document, you'll see many things that will make you scratch you
2020

2121
## ggproto
2222

23-
All ggplot2 objects are built using the ggproto system of object oriented programming. This OO system is used only in one place: ggplot2. This is mostly historical accident: ggplot2 started off using [proto](https://cran.r-project.org/web/packages/proto) because I needed mutable objects. This was well before the creation of (the briefly lived) [mutatr](http://vita.had.co.nz/papers/mutatr.html), reference classes and R6: proto was the only game in town.
23+
All ggplot2 objects are built using the ggproto system of object oriented programming. This OO system is used only in one place: ggplot2. This is mostly historical accident: ggplot2 started off using [proto]( https://cran.r-project.org/package=proto) because I needed mutable objects. This was well before the creation of (the briefly lived) [mutatr](http://vita.had.co.nz/papers/mutatr.html), reference classes and R6: proto was the only game in town.
2424

2525
But why ggproto? Well when we turned to add an official extension mechanism to ggplot2, we found a major problem that caused problems when proto objects were extended in a different package (methods were evaluated in ggplot2, not the package where the extension was added). We tried converting to R6, but it was a poor fit for the needs of ggplot2. We could've modified proto, but that would've first involved understand exactly how proto worked, and secondly making sure that the changes didn't affect other users of proto.
2626

0 commit comments

Comments
 (0)