Skip to content

Should accent argument be accessible from theme_grey(), theme_classic() etc along with paper and ink #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EvaMaeRey opened this issue Apr 9, 2025 · 1 comment · May be fixed by #6438
Labels
feature a feature request or enhancement themes 💃

Comments

@EvaMaeRey
Copy link

EvaMaeRey commented Apr 9, 2025

The new theming system means that the look and feel of plots can be dramatically changed - even just by using base ggplot2 convenience functions theme_grey(), theme_classic() etc. 🎉

Currently, paper and ink are arguments in these functions that let users change the background and forground colors - including layer colors! (amazing!)

However, the user cannot change the accent color (blue in geom_smooth for example) as theme_grey and friends are currently written. This feels a bit strange to me, because you can affect the colors (as well as size) for all grobs from the convience theme_* functions -- except if the grob happens to be defined by accent. But the geom_smooth's blue (and a handful of other grobs') is untouchable unless you learn or find some more involved syntax.

Just knowing geom_smooth's popularity and use in a lot of ggplot2 education to demonstrate building up plot layers, I wonder if making accent available in theme functions could be considered. 🙏

@teunbrand
Copy link
Collaborator

Hi Gina, sorry it took a while to get back to you! Do you happed to be interested in putting together a PR for this?

@teunbrand teunbrand added themes 💃 feature a feature request or enhancement labels Apr 22, 2025
@teunbrand teunbrand linked a pull request Apr 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement themes 💃
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants