-
Notifications
You must be signed in to change notification settings - Fork 2
/
Copy pathTODO
203 lines (136 loc) · 7.76 KB
/
TODO
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
- case of Boccardo Jean 1942-03-06 : date updated to 1942-03-16 and slug not updated
=> check ALL tmp2db and change slugs when not done
- Harmonize voc Group::createFromSlug() and Person:getFromSlug()
- D6 => reintegrate correctly addGeo + add DATE-UT computation + write corresponding issues
- create group definition files in db/group/csicop, and use them for group creation in class commands/csicop/CSICOP - use class ErtelSport as an example.
Fix addOccu to avoid duplicates:
beltoise-jean-pierre-1937-04-26 E3-95 ES-332 CF-144 3 motor-sports-competitor+motor-sports-competitor
Some TZO are missing
ex: beltoise-jean-pierre-1937-04-26
baumer-gertrud-1873-09-12 => ü is uppercased
Handle duplicates
2 d-aragona-ludovico (A5-1640) 1876-05-23 02:10:04 CERNUSCO SUL NA
2 gauquelin-a6-1496 (A6-1496) 1876-05-23 02:10:04 CERNUSCO SUL NA
4649 | bassot-jean-1841-04-06 | {"lerrcp": "A2-2563"} | 1841-04-06 21:01:29 | Renève
5860 | bassot-leon-1841-04-06 | {"lerrcp": "A3-132"} | 1841-04-06 21:01:29 | Renève
GQ: A2-1462 Gayda Tullio 1882-10-19 05:55:04 ROMA
GQ: A3-1697 Gauquelin-A3-1697 1882-10-19 20:10:04 ROMA
A2-3203 Becker
A2-3204 Friedrich Becker
cf duplicate Saint-Exupéry
- see php bug - https://bugs.php.net/bug.php?id=81002
(to store booleans in postgres)
- Check if admin level 1, 2, 3 should use codes like ISO 3166-2
- CFEPP
- match tmp file to geonames
- problem of issues
- recompute look inter
- See $cmdSignature in cfepp/final3/tmp2db and generalize it to all commands
- Harmonize export commands:
- computation of name using Person->fullName() and givenName() (see commands/db/export/allpersons).
- idem for function to sort by name
- factorize some functions passed in $fmap to Group::export() ; put them in class commands/db/Export
- Doc, install : document additions of views for postgrest api.
- names['nobl'] => include space when needed ('de ', 'di '...)
- Harmonize group creation => in data/db/group and remove from the code (class M5medics::getGroup() etc.)
- Clarify sources : maybe remove Gauquelin and Muller as sources
- Modify Person->updateFields():
- The function should take care of addOccus(), addIdInSource(), addIdPartial(), addIssues() etc.
- This would permit to simplify all tmp2db commands: everything is added to $new
and updateFields() takes the necessary precautions to update the person
- In docs/, replace references to g5.tig12.net by new url
- Write command db/export/allhistory.php
- remove useless fields from table source:
replace title, isbn etc by 'details', kv map depending on source type.
- integrate muller 1083 fix cura days and names to db/init/all
- add field 'lmt' in person birth - in Muller 612 men and 234 women, put LMT info in field birth.lmt instead of birth.note.
- add field 'notime' in person birth
=> DONE - must be tested
- add notes and issues in tmp2db
- add commit / rollback for all tmp2db commands ?
- grep -rn 'DB5::getDbLink()' src/
=> refactor: dblink must be passed in parameter to model classes, initialized in commands
=> commit / rollback possible
- scans of data/auxiliary/1991-muller1-writers are incomplete
Ask for new complete version and include supplementary fields in g5
- in all tweak2db : add function tweakFileName in "command model" classes (already done in Ertel4391)
- Use data/auxiliary/muller1-22-writers to check Gauquelin birth time errors - compare with results of raw2tmp / tmp2db
- add SI42 to auxiliary data - see data/auxiliary/1979-csicop
- add field notes in Person (useful for D10, fields corrected in APP)
(also useful in E1 E3)
- systematic rewiew of C1, C2, C3, in particular for USA
- Add children computation in db/init/occus1
- quasimodo-salvatore-1901-08-20: NAME not stored correctly in history
history | [{"new": {"sex": "M", "name": {"given": "Salvatore", "family": "Quasimodo"}, "birth": {"tzo": "+01:00", "date": "1901-08-20 18:00", "note": "", "place": {"c2": "SR", "cy": "IT", "lg": "15", "lat": "37", "name": "Siracusa"}}, "occus": ["writer"], "trust": 4, "sources": "afd1", "ids_in_sources": {"afd": "M1-367", "afd1": "367"}}, "raw": {"LG": "-15,5", "DAY": "20", "LAT": "37", "MIN": "00", "TZO": "-1", "HOUR": "18", "NAME": "367M Quasimodo, Salvatore", "YEAR": "1901", "MONTH": "08", "PLACE": "Siracusa SR"}, "date": "2021-09-19T16:55:03+02:00", "source": "afd1", "command": "cura muller402 tmp2db"}]
- quasimodo-salvatore-1901-08-20: Hour incoherent between M1-367 (18:00) and M2-457 (04:10)
BUG: AFD2 id not added in db
- AFD2:
- check 17 Arrau, Claudio (south lat)
- check 202 Franz II., Joseph Karl (-.50) tz offset (instead of -0.50)
- case 34 Bastian Adolf 1826-06-26 00:30 / 1826-06-25 23:54:40 for Gauquelin
(both correct but legal to UT make day change).
- 182 Gabriel Fauré => Gauquelin / Müller dates differ => check civil registries
- 456 Quadflieg, Will A5-1225 => Gauquelin / Müller dates differ => check civil registries
- 23 Balla, Giacomo is born 19.07.1871, but 18.07 according to wikipedia
- 102 Cage, John => Gauquelin / Müller dates differ => check civil registries
- try to match with Gauquelin
- MU: 162 Duvivier Julien
- MU: 384 Messerschmitt Willy
- MU: 292 Junkers Hugo
- A2 : Auguste / Jean Piccard: who is who ?
Associated A A2-3343 and J A2-3344 to match astrotheme.fr data (A: 23h - J: 22h45)
But possible error: astrotheme.fr hours differ from cura, need to check civil registry.
The association is done in tmp2db of Muller AFD2 312 famous men.
- AFD3:
- refactor using common code with AFD2
- check if mb_substr is needed
- simplify name (remove name2 and 3)
- E1 E3 / 'L' => compagnon de la libération
- in all tmp2db, when $p->addHistory is done,
$p->addSource and $p->addIdInSource are not taken into account
- refactor group export mechanism
Group::export() shouldn't store on disk
Modify articulation between commands/db/export/occu and alloccus (storage should be done in occu)
- check doc of page A with the results of
php run-g5.php cura A1 look count
- better the output of
php run-g5.php cura A1 raw2tmp full
to prepare complete restoration
- check pertinence of
grep -rn '0777' src/
- addGeo (compute geonames) for D10 ?
- See the difference in export of physicians
Counting the nb of unique physicians in each group :
2551 come from A2
976 come from E3
224 come from Muller 1083
2551+977+224 = 3751
The export says 3748, there is a difference of 3 that I can't explain, I marked it as a potential bug to check.
- Update Muller1083 documentation
- cura : handle all cases of unexisting raw files
- Refactor g55 commands : "all" is useless
- Write command export for g55
- G55::prepareCuraMatch not designed correctly
- fix nobilities in cura files
- Harmonize POSSIBLE_PARAMS in commands ; use model of muller1083/fixGnr (key val pairs)
Harmonize messages for wrong parameters
- Use Müller 1083MED to test legal time restoration on serie A
- A : legal time restoration for other countries.
- D6 D10 E1 E3 : compute timezone
- D6 addGeo : add also C2
- E1 notice : "NUM : Number (from 1 to 2145 ; 11 items have been added but n. 285 & n. 1155 are omitted)"
why ?
---- BUGS -----
- check birth in A1
from command
php run-g5.php g55 570SPO edited2cura date
1761 NAT 1927-11-11 Casteur Odette : 22:53 | 23:53
Strange to have birth time with minutes in 1927
883 CYC 1884-04-07 Seres Georges : 21:04 | 21:00
1934 RUG 1890-04-22 Lerou Roger : 22:55 | 23:00
2044 TEN 1886-12-12 Blanchy François : 08:55 | 09:00
2083 TIR 1876-05-29 Parmentier André : 03:55 | 04:00
Equation of time problem in legal time restoration ?
- In 570SPO generated :
A1-81 Winter Paul ATH 1906-02-06 14:00-01 RIBEAUVILLE FR 68 7.35 48.08333
Why tz offset misses ':00' ?