Skip to content

Multi-targeting (netstandard2.1, net7.0, net8.0, net9.0) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tintoy opened this issue Dec 3, 2024 · 3 comments
Closed

Multi-targeting (netstandard2.1, net7.0, net8.0, net9.0) #167

tintoy opened this issue Dec 3, 2024 · 3 comments
Assignees
Labels
breaking-change/binary Breaking change in binary compatibility; potential issue for upstream consumers if when upgrading. dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@tintoy
Copy link
Owner

tintoy commented Dec 3, 2024

Note - breaking changes in net9.0:

https://learn.microsoft.com/en-us/dotnet/core/compatibility/9.0

@tintoy tintoy added enhancement New feature or request breaking-change/binary Breaking change in binary compatibility; potential issue for upstream consumers if when upgrading. dependencies Pull requests that update a dependency file labels Dec 3, 2024
@tintoy tintoy self-assigned this Dec 3, 2024
tintoy added a commit that referenced this issue Dec 3, 2024
@raman-m
Copy link

raman-m commented Dec 10, 2024

Please be aware that Microsoft has not supported .NET 7 since May 2024 →

It appears that the net7.0 target should be removed from the list.

@tintoy
Copy link
Owner Author

tintoy commented Dec 11, 2024

Unfortunately, I know of at least one (commercial, closed-source) project that uses dotnet-kube-client but can't be upgraded to net8.0 yet (yes, I know, but it's not my call to make in that particular case).

net9.0 introduces quite a few breaking changes and deprecations, BTW.

Once we have stabilised everything, then yes - my plan is to drop net7.0.

@tintoy tintoy changed the title Multi-targeting (netstandard2.1, net7.0, net8.0, net9.0)O Multi-targeting (netstandard2.1, net7.0, net8.0, net9.0) Dec 28, 2024
@tintoy
Copy link
Owner Author

tintoy commented Dec 28, 2024

This working is pretty much complete at this stage; no major issues have arisen from multi-targeting so far.

Any remaining work will be handled by the completion of #166.

@tintoy tintoy closed this as completed Dec 28, 2024
tintoy added a commit to tintoy/Ocelot that referenced this issue Mar 15, 2025
KubeClient v3 should simplify dependency-management, from Ocelot's perspective:

* KubeClient no longer has an external dependency (HTTPlease) for its HttpClient support.
  The internalised version of this support is now located in the KubeClient.Http namespace.
* KubeClient v3 is multi-targeted for net9.0, as well as a couple of older versions that some consumers are still using (support for these older versions will be tailed off over the next couple of minor releases)

Related discussion at:

tintoy/dotnet-kube-client#166
tintoy/dotnet-kube-client#167
raman-m added a commit to ThreeMammals/Ocelot that referenced this issue Mar 18, 2025
* Upgrade to KubeClient v3 and log failed Kubernetes API requests

KubeClient v3 should simplify dependency-management, from Ocelot's perspective:

* KubeClient no longer has an external dependency (HTTPlease) for its HttpClient support.
  The internalised version of this support is now located in the KubeClient.Http namespace.
* KubeClient v3 is multi-targeted for net9.0, as well as a couple of older versions that some consumers are still using (support for these older versions will be tailed off over the next couple of minor releases)

Related discussion at:

tintoy/dotnet-kube-client#166
tintoy/dotnet-kube-client#167

* Don't attempt to deserialise response payload from Kubernetes API if it isn't going to be used

* Simplify logging implementation  by moving it out of EndPointClientV1 and into its caller

* Add support for returning error responses from the fake Kubernetes API used by service-discovery tests

* Revert "Add support for returning error responses from the fake Kubernetes API used by service-discovery tests"
This reverts commit 9a8bf9c.

* Upgrade KubeClient to v3.0.1

* Use consistent serialisation settings for fake Kubernetes API responses

* Add unit tests for handling of error responses from Kubernetes API

* Code review by @raman-m

* Change EndPointClientV1.GetAsync into a non-async wrapper method, since it only has a single await as the last statement (return await)

* Update docs with user's instructions

---------

Co-authored-by: Raman Maksimchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change/binary Breaking change in binary compatibility; potential issue for upstream consumers if when upgrading. dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants