-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
slabtop: add page #19301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
slabtop: add page #19301
Conversation
|
The build for this PR failed with the following error(s) at commit Please fix the error(s) and push again. |
Co-authored-by: Sahil Afrid Farookhi <[email protected]>
Co-authored-by: Sahil Afrid Farookhi <[email protected]>
ivanbaluta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi zhb4!
I've noticed one important issue that needs to be addressed. The slabtop command requires root privileges to read kernel slab information from /proc/slabinfo.
Please add sudo to the beginning of all the examples (except for the --help one). Without it, the commands will fail with a "Permission denied" error.
ivanbaluta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the --sort option expects a single character (e.g., c for cache size, o for number of objects), not a full word.
Co-authored-by: Ivan Baluta <[email protected]>
Co-authored-by: Ivan Baluta <[email protected]>
Co-authored-by: Ivan Baluta <[email protected]>
Co-authored-by: Ivan Baluta <[email protected]>
ivanbaluta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also add mnemonics to the sort descriptions
Co-authored-by: Ivan Baluta <[email protected]>
Co-authored-by: Ivan Baluta <[email protected]>
Co-authored-by: Ivan Baluta <[email protected]>
Checklist
common,linux,osx,windows,sunos,android, etc.Reference issue: #