Skip to content

Commit d7f752d

Browse files
committed
env value for app installation url in github integration
1 parent b7047df commit d7f752d

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/release.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ jobs:
8484
SENTRY_CLIENT_ID: ${{ secrets.SENTRY_STAGING_CLIENT_ID }}
8585
SENTRY_CLIENT_SECRET: ${{ secrets.SENTRY_STAGING_CLIENT_SECRET }}
8686
SENTRY_GITBOOK_INTEGRATION: ${{ secrets.SENTRY_STAGING_GITBOOK_INTEGRATION }}
87+
GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_STAGING_APP_INSTALL_URL }}
8788
GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_STAGING_APP_ID }}
8889
GITHUB_CLIENT_ID: ${{ secrets.GITBOOK_GITHUB_STAGING_CLIENT_ID }}
8990
GITHUB_CLIENT_SECRET: ${{ secrets.GITBOOK_GITHUB_STAGING_CLIENT_SECRET }}
@@ -125,6 +126,7 @@ jobs:
125126
JIRA_CLIENT_SECRET: ${{ secrets.JIRA_PROD_CLIENT_SECRET }}
126127
LINEAR_CLIENT_ID: ${{ secrets.LINEAR_PROD_CLIENT_ID }}
127128
LINEAR_CLIENT_SECRET: ${{ secrets.LINEAR_PROD_CLIENT_SECRET }}
129+
GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_APP_INSTALL_URL }}
128130
GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_APP_ID }}
129131
GITHUB_CLIENT_ID: ${{ secrets.GITBOOK_GITHUB_CLIENT_ID }}
130132
GITHUB_CLIENT_SECRET: ${{ secrets.GITBOOK_GITHUB_CLIENT_SECRET }}

integrations/github/gitbook-manifest.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ configurations:
4242
space:
4343
componentId: configure
4444
secrets:
45+
APP_INSTALL_URL: ${{ env.GITHUB_APP_INSTALL_URL }}
4546
APP_ID: ${{ env.GITHUB_APP_ID }}
4647
PRIVATE_KEY: ${{ env.GITHUB_PRIVATE_KEY }}
4748
CLIENT_ID: ${{ env.GITHUB_CLIENT_ID }}

integrations/github/src/components.tsx

+2-3
Original file line numberDiff line numberDiff line change
@@ -154,13 +154,12 @@ export const configBlock = createComponent<
154154
label="Select account"
155155
hint={
156156
<text>
157-
Choose the GitHub installation, user or organization.
157+
Choose the GitHub installation, user or organization.{' '}
158158
<link
159159
target={{
160-
url: 'https://github.com/apps/gitbook-com/installations/new',
160+
url: context.environment.secrets.APP_INSTALL_URL,
161161
}}
162162
>
163-
{' '}
164163
Install the GitHub app.
165164
</link>
166165
</text>

0 commit comments

Comments
 (0)