Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.52.2: test_global_options and test_global_session_env_options fail #961

Open
dvzrv opened this issue Feb 14, 2025 · 0 comments
Open

1.52.2: test_global_options and test_global_session_env_options fail #961

dvzrv opened this issue Feb 14, 2025 · 0 comments

Comments

@dvzrv
Copy link

dvzrv commented Feb 14, 2025

Hi! 👋
When trying to package 1.52.2 on Arch Linux I ran into test_global_options and test_global_session_env_options failing.

=================================== FAILURES ===================================
_____________________________ test_global_options ______________________________
tests/workspace/test_builder.py:252: in test_global_options
    builder.build(session=session)
        builder    = <tmuxp.workspace.builder.WorkspaceBuilder object at 0x763d337fb2a0>
        session    = Session($1 libtmux_on0xqzf_)
        workspace  = {'global_options': {'repeat-time': 493, 'status-position': 'top'},
 'session_name': 'test global options',
 'start_directory': '/tmp/pytest-of-builduser/pytest-0/home0/builduser',
 'windows': [{'panes': [{'shell_command': []},
                        {'shell_command': []},
                        {'shell_command': []}],
              'window_name': 'moo'}]}
test_dir/usr/lib/python3.13/site-packages/tmuxp/workspace/builder.py:310: in build
    self.session.set_option(option, value, global_=True)
E   TypeError: Session.set_option() got an unexpected keyword argument 'global_'. Did you mean '_global'?
        append     = False
        focus      = None
        option     = 'repeat-time'
        self       = <tmuxp.workspace.builder.WorkspaceBuilder object at 0x763d337fb2a0>
        session    = Session($1 libtmux_on0xqzf_)
        value      = 493
_______________________ test_global_session_env_options ________________________
tests/workspace/test_builder.py:278: in test_global_session_env_options
    builder.build(session=session)
        builder    = <tmuxp.workspace.builder.WorkspaceBuilder object at 0x763d3322a350>
        main_pane_height = 8
        monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x763d3322bee0>
        repeat_time = 738
        session    = Session($1 libtmux_ty4v9am8)
        visual_silence = 'on'
        workspace  = {'global_options': {'visual-silence': 'on'},
 'options': {'repeat-time': 738},
 'session_name': 'test env vars for options',
 'start_directory': '/tmp/pytest-of-builduser/pytest-0/home0/builduser',
 'windows': [{'layout': 'main-horizontal',
              'options': {'main-pane-height': '8'},
              'panes': [{'shell_command': []}],
              'window_name': 'moo'}]}
test_dir/usr/lib/python3.13/site-packages/tmuxp/workspace/builder.py:310: in build
    self.session.set_option(option, value, global_=True)
E   TypeError: Session.set_option() got an unexpected keyword argument 'global_'. Did you mean '_global'?
        append     = False
        focus      = None
        option     = 'visual-silence'
        self       = <tmuxp.workspace.builder.WorkspaceBuilder object at 0x763d3322a350>
        session    = Session($1 libtmux_ty4v9am8)
        value      = 'on'
=============================== warnings summary ===============================
tests/cli/test_cli.py::test_reattach_plugins
  /build/tmuxp/src/tmuxp-1.52.2/test_dir/usr/lib/python3.13/site-packages/tmuxp/cli/load.py:127: DeprecationWarning: Session.attach_session() is deprecated in favor of Session.attach()
    builder.session.attach_session()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/workspace/test_builder.py::test_global_options - TypeError: Session.set_option() got an unexpected keyword argument 'global_'. Did you mean '_global'?
FAILED tests/workspace/test_builder.py::test_global_session_env_options - TypeError: Session.set_option() got an unexpected keyword argument 'global_'. Did you mean '_global'?

tmuxp-1.52.2-1-x86_64-build.log
tmuxp-1.52.2-1-x86_64-check.log

I will disable these tests as I don't know how to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant