fix(postgres)!: support ? placeholder (#5455)

* fix(postgres): support ? placehodler

* refactor impl

* refactor query parameter parsing

Author: geooo109

sqlglot/dialects/postgres.py

@@ -384,6 +384,7 @@ class Parser(parser.Parser):
 
         PLACEHOLDER_PARSERS = {
             **parser.Parser.PLACEHOLDER_PARSERS,
+            TokenType.PLACEHOLDER: lambda self: self.expression(exp.Placeholder, jdbc=True),
             TokenType.MOD: lambda self: self._parse_query_parameter(),
         }
 
@@ -816,6 +817,9 @@ def interval_sql(self, expression: exp.Interval) -> str:
             return super().interval_sql(expression)
 
         def placeholder_sql(self, expression: exp.Placeholder) -> str:
+            if expression.args.get("jdbc"):
+                return "?"
+
             this = f"({expression.name})" if expression.this else ""
             return f"{self.NAMED_PLACEHOLDER_TOKEN}{this}s"
 

sqlglot/expressions.py

@@ -4467,8 +4467,9 @@ class SessionParameter(Condition):
 
 
 # https://www.databricks.com/blog/parameterized-queries-pyspark
+# https://jdbc.postgresql.org/documentation/query/#using-the-statement-or-preparedstatement-interface
 class Placeholder(Condition):
-    arg_types = {"this": False, "kind": False, "widget": False}
+    arg_types = {"this": False, "kind": False, "widget": False, "jdbc": False}
 
     @property
     def name(self) -> str:

tests/dialects/test_postgres.py

@@ -923,6 +923,7 @@ def test_postgres(self):
 
         self.validate_identity("SELECT * FROM foo WHERE id = %s")
         self.validate_identity("SELECT * FROM foo WHERE id = %(id_param)s")
+        self.validate_identity("SELECT * FROM foo WHERE id = ?")
 
     def test_ddl(self):
         # Checks that user-defined types are parsed into DataType instead of Identifier