Chunk file streaming for improved performance #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbridge
force-pushed
the
fix/streamed-download-performance
branch
from
5db936b to
7df6bb7
Compare
zerolab
requested changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #43, this adds back in the
chunk_sizeargument which I previously removed from that PR: I mistakenly thought that8192was the defaultchunk_sizeforiter_content(), where in fact it's1: using such a small chunk size negatively affects the performance of the streaming download.As
iter_contentwith a specifiedchunk_sizewon't iterate if the response is empty, I've added a separate check to ensure any cases of this are raised as a validation error.