CR feedback

Author: henadzit

tortoise/backends/base/executor.py

@@ -114,7 +114,7 @@ async def execute_select(
                 for model, index, *__, full_path in self.select_related_idx[1:]:
                     (*path, attr) = full_path
                     related_items = row_items[current_idx : current_idx + index]
-                    if any((v for _, v in related_items)):
+                    if any(v for _, v in related_items):
                         obj = model._init_from_db(**{k.split(".")[1]: v for k, v in related_items})
                     elif index == 0:
                         # 0 signals that an empty "filler" object should be created in the case

tortoise/query_utils.py

@@ -89,6 +89,7 @@ def expand_lookup_expression(root_model: type[Model], lookup_expression: str) ->
         field = cast(RelationalField, model._meta.fields_map[field_name])
         fields.append(field)
         model = field.related_model
+    # the last field is not necessarily a RelationalField, so threting it differently
     try:
         fields.append(model._meta.fields_map[field_names[-1]])
     except KeyError: