Skip to content

False positive in 07-arrays problem #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talves opened this issue Sep 6, 2022 · 2 comments · Fixed by #29
Closed

False positive in 07-arrays problem #27

talves opened this issue Sep 6, 2022 · 2 comments · Fixed by #29

Comments

@talves
Copy link
Contributor

talves commented Sep 6, 2022

This could be construed as a tuple of type Post, but of course it's an array.

posts: [
{
id: 1,
title: "How I eat so much cheese",
},
],

It might be better to create an array example so it fails if a student set the user interface to [Post] which passes the type checks.

  posts: [
    {
      id: 1,
      title: "How I eat so much cheese",
    },
    {
      id: 2,
      title: "Why I don't eat vegetables",
    },
  ],
@hidaviddong
Copy link

#10

@mattpocock
Copy link
Collaborator

Makes sense - go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants