Skip to content

Add a preferred node version #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luischoma opened this issue Dec 22, 2022 · 2 comments
Closed

Add a preferred node version #70

luischoma opened this issue Dec 22, 2022 · 2 comments

Comments

@luischoma
Copy link

Hey!!

First of, thanks for the great and very useful initiative!

I would like to suggest adding a .nvmrc file to the project. The reason is that, on my case, I have an older node version installed and used by default. When trying to run the first exercise I would get this error:

  argv.passWithNoTests ?? (argv.passWithNoTests = true);
                        ^
SyntaxError: Unexpected token '?'

This is related to vite configs I guess, but since installing dependencies didn't throw any error took me a few minutes to realize it was the node version. Adding the preferred node version to the project would help to identify this earlier.

:)

@WikiRik
Copy link

WikiRik commented Dec 24, 2022

I believe all currently supported versions of Node should work, but considering that the installed version of @types/node is ^18.6.5 the recommended Node version to use would be 18.x

@mattpocock
Copy link
Collaborator

Hey! I think an LTS version of Node is a safe assumption for a project to make without needing to do anything our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants