Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fails if python is not installed #188

Open
webpro opened this issue Aug 21, 2023 · 6 comments · Fixed by #193
Open

Install fails if python is not installed #188

webpro opened this issue Aug 21, 2023 · 6 comments · Fixed by #193

Comments

@webpro
Copy link

webpro commented Aug 21, 2023

Just received this report: webpro-nl/knip#209

Maybe it's just me, but the python requirement wasn't clear to me when installing tree-sitter-bash. Could it be an issue specific to this Docker environment? Are prebuilt binaries available?

When I look at https://github.com/tree-sitter/tree-sitter-bash/tree/master/bindings it seems rust bindings have been updated with 0.20.0, but not the node bindings. Maybe something was forgotten when releasing 0.20.0? This release is also not listed on https://github.com/tree-sitter/tree-sitter-bash/releases currently.

@webpro
Copy link
Author

webpro commented Aug 21, 2023

Also see webpro-nl/knip#211 and specifically webpro-nl/knip#211 (comment)

@webpro
Copy link
Author

webpro commented Aug 23, 2023

Thanks, @amaanq.

I don't see the assets with either v0.20.0 or v0.20.2 (this one also doesn't have a release at all, only a tag), is there another mechanism now?

@amaanq
Copy link
Member

amaanq commented Aug 23, 2023

I added the "pack.yml" ci file which was meant to run when a release is created, but it did not, I could use some help figuring that out as I'm not well-versed in the CI/nodejs stuff

@webpro
Copy link
Author

webpro commented Aug 23, 2023

No worries, we're all in this together. I got some advice here: webpro-nl/knip#211 (comment)

For my own lib I just reverted back to the previous solution, no worries there.

Wish I could help you out here, but I don't have any experience with such releases/binaries for platforms, ets.

@amaanq
Copy link
Member

amaanq commented Aug 23, 2023

yeah one solution could be Max uploading the binaries

(paging @maxbrunsfeld)

@webpro
Copy link
Author

webpro commented Aug 25, 2023

Should we reopen this issue?

I'm also interested to know about how tree-sitter-node + tree-sitter-bash is supposed to be used as a dependency in projects like Knip. I just installed the deps + import them, did I miss something? (Here's what I did: webpro-nl/knip@93fecda...ef3981f)

I didn't encounter any issues on my own (macOS) machine and in the macos-latest, ubuntu-latest, windows-latest GitHub Action environments, but that's not the whole story for everyone (removed lines for brevity):

npm ERR! prebuild-install warn install No prebuilt binaries found (target=18.16.1 runtime=node arch=x64 libc= platform=linux)
...
npm ERR! gyp info using [email protected] | linux | x64
...
npm ERR! make: g++-10: No such file or directory

After reading webpro-nl/knip#211 (comment) and following the links I'm confused as to what environments exactly are supported.

Looking at the docs in this repo maybe this is more of a tree-sitter-node issue, but those docs also led me to believe there's no extra steps involved.

A "wontfix" is also an answer, but at this point I have no idea what to expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants