-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install fails if python is not installed #188
Comments
Also see webpro-nl/knip#211 and specifically webpro-nl/knip#211 (comment) |
I added the "pack.yml" ci file which was meant to run when a release is created, but it did not, I could use some help figuring that out as I'm not well-versed in the CI/nodejs stuff |
No worries, we're all in this together. I got some advice here: webpro-nl/knip#211 (comment) For my own lib I just reverted back to the previous solution, no worries there. Wish I could help you out here, but I don't have any experience with such releases/binaries for platforms, ets. |
yeah one solution could be Max uploading the binaries (paging @maxbrunsfeld) |
Should we reopen this issue? I'm also interested to know about how I didn't encounter any issues on my own (macOS) machine and in the
After reading webpro-nl/knip#211 (comment) and following the links I'm confused as to what environments exactly are supported. Looking at the docs in this repo maybe this is more of a tree-sitter-node issue, but those docs also led me to believe there's no extra steps involved. A "wontfix" is also an answer, but at this point I have no idea what to expect. |
Just received this report: webpro-nl/knip#209
Maybe it's just me, but the python requirement wasn't clear to me when installing tree-sitter-bash. Could it be an issue specific to this Docker environment? Are prebuilt binaries available?
When I look at https://github.com/tree-sitter/tree-sitter-bash/tree/master/bindings it seems rust bindings have been updated with 0.20.0, but not the node bindings. Maybe something was forgotten when releasing 0.20.0? This release is also not listed on https://github.com/tree-sitter/tree-sitter-bash/releases currently.
The text was updated successfully, but these errors were encountered: