Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parsing a complex string #252

Open
nordlow opened this issue Feb 13, 2024 · 2 comments
Open

Error parsing a complex string #252

nordlow opened this issue Feb 13, 2024 · 2 comments

Comments

@nordlow
Copy link
Contributor

nordlow commented Feb 13, 2024

The line

ret="${(S)1//"${_LP_OPEN_ESC}"*"${_LP_CLOSE_ESC}"}"

found at
https://github.com/liquidprompt/liquidprompt/blob/master/liquidprompt#L115

parses incorrectly in Emacs' tree-sitter-based bash-ts-mode but correctly in sh-mode.

@amaanq
Copy link
Member

amaanq commented Feb 13, 2024

Help me out here, is this valid bash? I have shellcheck complaining that parameter expansions can't start with (, is that true?

Ok I see they have a comment disabling that exact warning, maybe it is valid

Nvm, that looks like a zsh flag thing, if it is then it's not actionable here.

@nordlow
Copy link
Contributor Author

nordlow commented Feb 13, 2024

Nvm, that looks like a zsh flag thing, if it is then it's not actionable here.

At least, source liquidprompt in bash passes locally on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants