Add session properties configuration

Signed-off-by: Harry <[email protected]>

Author: sudohainguyen

charts/trino/README.md

@@ -349,6 +349,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
    - exchange.s3.aws-access-key=your-access-key
    - exchange.s3.aws-secret-key=your-secret-key
   ```
+* `sessionProperties` - string, default: `""`
 * `eventListenerProperties` - list, default: `[]`  
 
   [Event listener](https://trino.io/docs/current/develop/event-listener.html#event-listener) properties. To configure multiple event listeners, add them in `coordinator.additionalConfigFiles` and `worker.additionalConfigFiles`, and set the `event-listener.config-files` property in `additionalConfigProperties` to their locations.

charts/trino/templates/configmap-coordinator.yaml

@@ -117,6 +117,15 @@ data:
   {{- end }}
 {{- end }}
 
+{{- if .Values.sessionProperties }}
+  session-property-config.properties: |
+    session-property-config.configuration-manager=file
+    session-property-manager.config-file={{ .Values.server.config.path }}/session-property-config.json
+
+  session-property-config.json: |
+    {{- .Values.sessionProperties | nindent 4 }}
+{{- end }}
+
 {{- if .Values.server.exchangeManager }}
   exchange-manager.properties: |
     exchange-manager.name={{ .Values.server.exchangeManager.name }}

charts/trino/values.yaml

@@ -368,6 +368,37 @@ additionalExchangeManagerProperties: []
 #  - exchange.s3.aws-secret-key=your-secret-key
 # ```
 
+sessionProperties: ""
+# [Session property config file](https://trino.io/docs/current/admin/session-property-managers.html)
+# is mounted to {{ .Values.server.config.path }}/session-property-config.json
+# @raw
+# Example:
+# ```yaml
+# sessionProperties: |-
+#   [
+#     {
+#       "group": "global.*",
+#       "sessionProperties": {
+#         "query_max_execution_time": "8h"
+#       }
+#     },
+#     {
+#       "group": "global.interactive.*",
+#       "sessionProperties": {
+#         "query_max_execution_time": "1h"
+#       }
+#     },
+#     {
+#       "group": "global.pipeline.*",
+#       "clientTags": ["etl"],
+#       "sessionProperties": {
+#         "scale_writers": "true",
+#         "hive.insert_existing_partitions_behavior": "overwrite"
+#       }
+#     }
+#   ]
+# ```
+
 eventListenerProperties: []
 # eventListenerProperties -- [Event
 # listener](https://trino.io/docs/current/develop/event-listener.html#event-listener)

tests/trino/test-session-properties-values.yaml

@@ -0,0 +1,32 @@
+# Session Properties values to test.
+# This is a YAML-formatted file.
+
+server:
+  workers: 1
+
+# Testing session property configuration
+sessionProperties: |-
+  [
+    {
+      "group": "global.*",
+      "sessionProperties": {
+        "query_max_execution_time": "8h",
+        "distributed_join": "true"
+      }
+    },
+    {
+      "group": "global.interactive.*",
+      "sessionProperties": {
+        "query_max_execution_time": "1h",
+        "task_concurrency": "4"
+      }
+    },
+    {
+      "group": "global.pipeline.*",
+      "clientTags": ["etl"],
+      "sessionProperties": {
+        "scale_writers": "true",
+        "hive.insert_existing_partitions_behavior": "overwrite"
+      }
+    }
+  ]

tests/trino/test.sh

@@ -11,6 +11,7 @@ declare -A testCases=(
     [exchange_manager_values]="--values test-exchange-manager-values.yaml"
     [graceful_shutdown]="--values test-graceful-shutdown-values.yaml"
     [resource_groups_properties]="--values test-resource-groups-properties-values.yaml"
+    [session_properties]="--values test-session-properties-values.yaml"
 )
 
 declare -A testCaseCharts=(
@@ -22,6 +23,7 @@ declare -A testCaseCharts=(
     [exchange_manager_values]="../../charts/trino"
     [graceful_shutdown]="../../charts/trino"
     [resource_groups_properties]="../../charts/trino"
+    [session_properties]="../../charts/trino"
 )
 
 function join_by {
@@ -41,7 +43,7 @@ CT_ARGS=(
     --helm-extra-args="--timeout 2m"
 )
 CLEANUP_NAMESPACE=true
-TEST_NAMES=(default single_node complete_values access_control_properties_values exchange_manager_values graceful_shutdown resource_groups_properties)
+TEST_NAMES=(default single_node complete_values access_control_properties_values exchange_manager_values graceful_shutdown resource_groups_properties session_properties)
 
 usage() {
     cat <<EOF 1>&2