Skip to content

Commit 48a9bfc

Browse files
committed
- fixed checkstyle violations after enabling checkstyle plugin
1 parent 95ed9f8 commit 48a9bfc

File tree

4 files changed

+29
-27
lines changed

4 files changed

+29
-27
lines changed

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,8 @@ private static String getTimestampBindExpression(int precision)
527527
{
528528
if (precision <= 0) {
529529
return "TO_TIMESTAMP(?, 'YYYY-MM-DD HH24:MI:SS')";
530-
} else {
530+
}
531+
else {
531532
return format("TO_TIMESTAMP(?, 'YYYY-MM-DD HH24:MI:SS.FF%d')", precision);
532533
}
533534
}

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClientModule.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,24 +13,28 @@
1313
*/
1414
package io.trino.plugin.exasol;
1515

16-
import static com.google.inject.multibindings.Multibinder.newSetBinder;
17-
import static io.airlift.configuration.ConfigBinder.configBinder;
18-
19-
import java.util.Properties;
20-
2116
import com.exasol.jdbc.EXADriver;
2217
import com.google.inject.Binder;
2318
import com.google.inject.Provides;
2419
import com.google.inject.Scopes;
2520
import com.google.inject.Singleton;
26-
2721
import io.airlift.configuration.AbstractConfigurationAwareModule;
2822
import io.opentelemetry.api.OpenTelemetry;
29-
import io.trino.plugin.jdbc.*;
23+
import io.trino.plugin.jdbc.BaseJdbcConfig;
24+
import io.trino.plugin.jdbc.ConnectionFactory;
25+
import io.trino.plugin.jdbc.DriverConnectionFactory;
26+
import io.trino.plugin.jdbc.ForBaseJdbc;
27+
import io.trino.plugin.jdbc.JdbcClient;
28+
import io.trino.plugin.jdbc.JdbcStatisticsConfig;
3029
import io.trino.plugin.jdbc.credential.CredentialProvider;
3130
import io.trino.plugin.jdbc.ptf.Query;
3231
import io.trino.spi.function.table.ConnectorTableFunction;
3332

33+
import java.util.Properties;
34+
35+
import static com.google.inject.multibindings.Multibinder.newSetBinder;
36+
import static io.airlift.configuration.ConfigBinder.configBinder;
37+
3438
public class ExasolClientModule
3539
extends AbstractConfigurationAwareModule
3640
{

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -61,25 +61,25 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
6161
return switch (connectorBehavior) {
6262
// Tests requires write access which is not implemented
6363
case SUPPORTS_AGGREGATION_PUSHDOWN,
64-
SUPPORTS_JOIN_PUSHDOWN,
65-
SUPPORTS_LIMIT_PUSHDOWN,
66-
SUPPORTS_TOPN_PUSHDOWN -> false;
64+
SUPPORTS_JOIN_PUSHDOWN,
65+
SUPPORTS_LIMIT_PUSHDOWN,
66+
SUPPORTS_TOPN_PUSHDOWN -> false;
6767

6868
// Parallel writing is not supported due to restrictions of the Exasol JDBC driver.
6969
case SUPPORTS_ADD_COLUMN,
70-
SUPPORTS_ARRAY,
71-
SUPPORTS_COMMENT_ON_TABLE,
72-
SUPPORTS_CREATE_SCHEMA,
73-
SUPPORTS_CREATE_TABLE,
74-
SUPPORTS_DELETE,
75-
SUPPORTS_INSERT,
76-
SUPPORTS_MAP_TYPE,
77-
SUPPORTS_NEGATIVE_DATE, // min date is 0001-01-01
78-
SUPPORTS_RENAME_COLUMN,
79-
SUPPORTS_RENAME_TABLE,
80-
SUPPORTS_ROW_TYPE,
81-
SUPPORTS_SET_COLUMN_TYPE,
82-
SUPPORTS_UPDATE -> false;
70+
SUPPORTS_ARRAY,
71+
SUPPORTS_COMMENT_ON_TABLE,
72+
SUPPORTS_CREATE_SCHEMA,
73+
SUPPORTS_CREATE_TABLE,
74+
SUPPORTS_DELETE,
75+
SUPPORTS_INSERT,
76+
SUPPORTS_MAP_TYPE,
77+
SUPPORTS_NEGATIVE_DATE, // min date is 0001-01-01
78+
SUPPORTS_RENAME_COLUMN,
79+
SUPPORTS_RENAME_TABLE,
80+
SUPPORTS_ROW_TYPE,
81+
SUPPORTS_SET_COLUMN_TYPE,
82+
SUPPORTS_UPDATE -> false;
8383

8484
default -> super.hasBehavior(connectorBehavior);
8585
};

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
import io.trino.Session;
1717
import io.trino.spi.type.TimeZoneKey;
18-
import io.trino.spi.type.TimestampWithTimeZoneType;
1918
import io.trino.testing.AbstractTestQueryFramework;
2019
import io.trino.testing.QueryRunner;
2120
import io.trino.testing.TestingSession;
@@ -301,7 +300,6 @@ public void testTimestampWithTimeZone()
301300
public void testUnsupportedTimestampValues()
302301
{
303302
try (TestTable table = new TestTable(exasolServer::execute, "tpch.test_unsupported_timestamp", "(col TIMESTAMP)")) {
304-
305303
// Too early
306304
assertExasolQueryFails(
307305
"INSERT INTO " + table.getName() + " VALUES (TIMESTAMP '0000-12-31 23:59:59.999999')",
@@ -326,7 +324,6 @@ private void assertExasolQueryFails(String sql, String expectedMessage)
326324
.hasMessageContaining(expectedMessage);
327325
}
328326

329-
330327
/**
331328
* <p>
332329
* <b>Important timezone note:</b> The input timestamp string literal is interpreted as a timestamp

0 commit comments

Comments
 (0)