Skip to content

Commit e401847

Browse files
committed
Remove no longer needed optimization
Since FasterXML/jackson-core#1081 this optimization does no longer make sense as it's applied internally by Jackson if needed.
1 parent 00c136d commit e401847

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

core/trino-main/src/main/java/io/trino/util/JsonUtil.java

-11
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
import java.io.IOException;
6464
import java.io.InputStreamReader;
6565
import java.io.OutputStream;
66-
import java.io.StringReader;
6766
import java.math.BigDecimal;
6867
import java.util.ArrayList;
6968
import java.util.HashMap;
@@ -106,9 +105,6 @@
106105

107106
public final class JsonUtil
108107
{
109-
// StringReader outperforms InputStreamReader for small inputs. Limit based on Jackson benchmarks {@link https://github.com/FasterXML/jackson-benchmarks/pull/9}
110-
private static final int STRING_READER_LENGTH_LIMIT = 8192;
111-
112108
private JsonUtil() {}
113109

114110
// This object mapper is constructed without .configure(ORDER_MAP_ENTRIES_BY_KEYS, true) because
@@ -127,13 +123,6 @@ public static JsonFactory createJsonFactory()
127123
public static JsonParser createJsonParser(JsonFactory factory, Slice json)
128124
throws IOException
129125
{
130-
// Jackson tries to detect the character encoding automatically when using InputStream
131-
// so we pass StringReader or an InputStreamReader instead.
132-
if (json.length() < STRING_READER_LENGTH_LIMIT) {
133-
// StringReader is more performant than InputStreamReader for small inputs
134-
return factory.createParser(new StringReader(new String(json.getBytes(), UTF_8)));
135-
}
136-
137126
return factory.createParser(new InputStreamReader(json.getInput(), UTF_8));
138127
}
139128

0 commit comments

Comments
 (0)